[ios] Convert Showcase Infobar tests to EG2

Adds a new "constants" source_set to avoid any chrome/app
dependencies.

Bug: 987646
Change-Id: I8fc61687cabc0618e43a7dcc92c30c5cf694e6af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906893Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715020}

ios/showcase/BUILD.gn

@@ -79,6 +79,7 @@ ios_eg2_test("ios_showcase_eg2tests_module") {
   xctest_bundle_principal_class = "ChromeEGTestBundleMain"
   deps = [
     "//ios/showcase/content_suggestions:eg2_tests",
+    "//ios/showcase/infobars:eg2_tests",
   ]
   bundle_deps = [ "//ios/showcase/core/resources" ]
 }

ios/showcase/infobars/BUILD.gn

@@ -12,6 +12,7 @@ source_set("infobars") {
     "sc_infobar_container_view_controller.mm",
   ]
   deps = [
+    ":constants",
     "//ios/chrome/browser/infobars:public",
     "//ios/chrome/browser/ui/infobars/banners",
     "//ios/chrome/browser/ui/infobars/coordinators",
@@ -23,18 +24,52 @@ source_set("infobars") {
   configs += [ "//build/config/compiler:enable_arc" ]
 }
 
+source_set("constants") {
+  sources = [
+    "sc_infobar_constants.h",
+    "sc_infobar_constants.mm",
+  ]
+  deps = []
+  configs += [ "//build/config/compiler:enable_arc" ]
+}
+
+source_set("eg2_tests") {
+  defines = [ "CHROME_EARL_GREY_2" ]
+  configs += [
+    "//build/config/compiler:enable_arc",
+    "//build/config/ios:xctest_config",
+  ]
+  testonly = true
+  sources = [
+    "sc_infobar_banner_coordinator_egtest.mm",
+    "sc_infobar_banner_no_modal_coordinator_egtest.mm",
+  ]
+  deps = [
+    ":constants",
+    "//ios/chrome/browser/ui/infobars/banners:public",
+    "//ios/chrome/browser/ui/infobars/modals:public",
+    "//ios/showcase/test:eg2_test",
+    "//ios/testing/earl_grey:eg_test_support+eg2",
+    "//ios/third_party/earl_grey2:test_lib",
+  ]
+  libs = [ "UIKit.framework" ]
+}
+
 source_set("eg_tests") {
   testonly = true
+  defines = [ "CHROME_EARL_GREY_1" ]
   sources = [
     "sc_infobar_banner_coordinator_egtest.mm",
     "sc_infobar_banner_no_modal_coordinator_egtest.mm",
   ]
   deps = [
+    ":constants",
     "//ios/chrome/browser/ui/infobars/banners:public",
     "//ios/chrome/browser/ui/infobars/modals:public",
     "//ios/chrome/test/earl_grey:test_support",
     "//ios/showcase/infobars",
     "//ios/showcase/test",
+    "//ios/testing/earl_grey:earl_grey_support",
   ]
   configs += [ "//build/config/compiler:enable_arc" ]
 }

ios/showcase/infobars/sc_infobar_banner_coordinator.mm

@@ -10,6 +10,7 @@
 #import "ios/chrome/browser/ui/infobars/modals/infobar_modal_delegate.h"
 #import "ios/chrome/browser/ui/infobars/modals/infobar_modal_view_controller.h"
 #import "ios/chrome/browser/ui/infobars/presentation/infobar_modal_transition_driver.h"
+#import "ios/showcase/infobars/sc_infobar_constants.h"
 #import "ios/showcase/infobars/sc_infobar_container_view_controller.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)

ios/showcase/infobars/sc_infobar_banner_coordinator_egtest.mm

@@ -2,13 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#import <EarlGrey/EarlGrey.h>
-
 #import "ios/chrome/browser/ui/infobars/banners/infobar_banner_constants.h"
 #import "ios/chrome/browser/ui/infobars/modals/infobar_modal_constants.h"
-#import "ios/showcase/infobars/sc_infobar_container_view_controller.h"
+#import "ios/showcase/infobars/sc_infobar_constants.h"
 #import "ios/showcase/test/showcase_eg_utils.h"
 #import "ios/showcase/test/showcase_test_case.h"
+#import "ios/testing/earl_grey/earl_grey_test.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."

ios/showcase/infobars/sc_infobar_banner_no_modal_coordinator.mm

@@ -8,6 +8,7 @@
 #import "ios/chrome/browser/ui/infobars/banners/infobar_banner_delegate.h"
 #import "ios/chrome/browser/ui/infobars/banners/infobar_banner_view_controller.h"
 #import "ios/chrome/browser/ui/infobars/presentation/infobar_banner_transition_driver.h"
+#import "ios/showcase/infobars/sc_infobar_constants.h"
 #import "ios/showcase/infobars/sc_infobar_container_view_controller.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)

ios/showcase/infobars/sc_infobar_banner_no_modal_coordinator_egtest.mm

@@ -2,13 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#import <EarlGrey/EarlGrey.h>
-
 #import "ios/chrome/browser/ui/infobars/banners/infobar_banner_constants.h"
 #import "ios/chrome/browser/ui/infobars/modals/infobar_modal_constants.h"
-#import "ios/showcase/infobars/sc_infobar_container_view_controller.h"
+#import "ios/showcase/infobars/sc_infobar_constants.h"
 #import "ios/showcase/test/showcase_eg_utils.h"
 #import "ios/showcase/test/showcase_test_case.h"
+#import "ios/testing/earl_grey/earl_grey_test.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."

ios/showcase/infobars/sc_infobar_constants.h

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_SHOWCASE_INFOBARS_SC_INFOBAR_CONSTANTS_H_
+#define IOS_SHOWCASE_INFOBARS_SC_INFOBAR_CONSTANTS_H_
+
+#import <UIKit/UIKit.h>
+
+extern NSString* const kInfobarBannerTitleLabel;
+extern NSString* const kInfobarBannerSubtitleLabel;
+extern NSString* const kInfobarBannerButtonLabel;
+extern NSString* const kInfobarBannerPresentedModalLabel;
+
+#endif  // IOS_SHOWCASE_INFOBARS_SC_INFOBAR_CONSTANTS_H_

ios/showcase/infobars/sc_infobar_constants.mm

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/showcase/infobars/sc_infobar_constants.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+NSString* const kInfobarBannerTitleLabel = @"Test Infobar";
+NSString* const kInfobarBannerSubtitleLabel = @"This a test Infobar.";
+NSString* const kInfobarBannerButtonLabel = @"Accept";
+NSString* const kInfobarBannerPresentedModalLabel = @"Modal Infobar";

ios/showcase/infobars/sc_infobar_container_view_controller.h

@@ -13,11 +13,6 @@
 @class InfobarBannerTransitionDriver;
 @class InfobarBannerViewController;
 
-extern NSString* const kInfobarBannerTitleLabel;
-extern NSString* const kInfobarBannerSubtitleLabel;
-extern NSString* const kInfobarBannerButtonLabel;
-extern NSString* const kInfobarBannerPresentedModalLabel;
-
 @interface ContainerViewController
     : UIViewController <InfobarBannerPositioner, InfobarModalPositioner>
 @property(nonatomic, strong) InfobarBannerViewController* bannerViewController;

ios/showcase/infobars/sc_infobar_container_view_controller.mm

@@ -12,11 +12,6 @@
 #error "This file requires ARC support."
 #endif
 
-NSString* const kInfobarBannerTitleLabel = @"Test Infobar";
-NSString* const kInfobarBannerSubtitleLabel = @"This a test Infobar.";
-NSString* const kInfobarBannerButtonLabel = @"Accept";
-NSString* const kInfobarBannerPresentedModalLabel = @"Modal Infobar";
-
 @implementation ContainerViewController
 - (void)viewDidAppear:(BOOL)animated {
   [super viewDidAppear:animated];