Add 8dp top padding to the long press history popup.

BUG=800033

Change-Id: I0007ae432782e4222f1eed4aad03259a9e25a784
Reviewed-on: https://chromium-review.googlesource.com/1167556Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581691}

chrome/android/java/res/layout/navigation_popup_item.xml

@@ -7,7 +7,7 @@
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
-    android:layout_height="@dimen/navigation_popup_item_height"
+    android:layout_height="wrap_content"
     android:paddingStart="@dimen/navigation_popup_default_padding"
     android:paddingEnd="@dimen/navigation_popup_default_padding"
     android:gravity="center_vertical"
@@ -32,9 +32,11 @@
 
     <TextView
         android:id="@+id/entry_title"
+        android:gravity="center_vertical"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginStart="@dimen/navigation_popup_default_padding"
+        android:minHeight="@dimen/navigation_popup_item_height"
         android:textAppearance="@style/BlackTitle1"
         android:singleLine="true" />
 </LinearLayout>
\ No newline at end of file

chrome/android/java/res/values/dimens.xml

@@ -593,5 +593,6 @@
     <dimen name="navigation_popup_width">312dp</dimen>
     <dimen name="navigation_popup_item_height">56dp</dimen>
     <dimen name="navigation_popup_default_padding">16dp</dimen>
+    <dimen name="navigation_popup_top_padding">8dp</dimen>
     <dimen name="navigation_popup_favicon_bg_size">36dp</dimen>
 </resources>

chrome/android/java/src/org/chromium/chrome/browser/NavigationPopup.java

@@ -260,7 +260,7 @@ public class NavigationPopup extends ListPopupWindow implements AdapterView.OnIt
     }
 
     private class NavigationAdapter extends BaseAdapter {
-        private boolean mInReverseOrder;
+        boolean mInReverseOrder;
 
         public void reverseOrder() {
             mInReverseOrder = true;
@@ -299,6 +299,8 @@ public class NavigationPopup extends ListPopupWindow implements AdapterView.OnIt
     }
 
     private class NewNavigationAdapter extends NavigationAdapter {
+        private Integer mTopPadding;
+
         @Override
         public View getView(int position, View convertView, ViewGroup parent) {
             EntryViewHolder viewHolder;
@@ -306,6 +308,7 @@ public class NavigationPopup extends ListPopupWindow implements AdapterView.OnIt
                 LayoutInflater inflater = LayoutInflater.from(parent.getContext());
                 convertView = inflater.inflate(R.layout.navigation_popup_item, parent, false);
                 viewHolder = new EntryViewHolder();
+                viewHolder.mContainer = convertView;
                 viewHolder.mImageView = convertView.findViewById(R.id.favicon_img);
                 viewHolder.mTextView = convertView.findViewById(R.id.entry_title);
                 convertView.setTag(viewHolder);
@@ -317,11 +320,23 @@ public class NavigationPopup extends ListPopupWindow implements AdapterView.OnIt
             setViewText(entry, viewHolder.mTextView);
             viewHolder.mImageView.setImageBitmap(entry.getFavicon());
 
+            if (mInReverseOrder) {
+                View container = viewHolder.mContainer;
+                if (mTopPadding == null) {
+                    mTopPadding = container.getResources().getDimensionPixelSize(
+                            R.dimen.navigation_popup_top_padding);
+                }
+                viewHolder.mContainer.setPadding(container.getPaddingLeft(),
+                        position == 0 ? mTopPadding : 0, container.getPaddingRight(),
+                        container.getPaddingBottom());
+            }
+
             return convertView;
         }
     }
 
     private static class EntryViewHolder {
+        View mContainer;
         ImageView mImageView;
         TextView mTextView;
     }