Commit e2284fd9 authored by rockot's avatar rockot Committed by Commit bot

Refine //extensions DEPS on //ui

This patch makes more explicit the set of dependencies
allowed from //extensions onto //ui.

//extensions was allowing dependencies on all of //ui
by default. This is unfortunate for people who want to
introduce new code into //extensions only to be shot
down because they depend on pieces of ui that aren't
allowed.

BUG=None

Review URL: https://codereview.chromium.org/702513002

Cr-Commit-Position: refs/heads/master@{#302637}
parent 2eb362d2
......@@ -13,7 +13,16 @@ include_rules = [
"+grit/extensions_resources.h",
"+mojo/public",
"+testing",
"+ui",
# Minimal UI dependencies. There are two good rules for UI dependencies here:
#
# 1) UI components should only be added as they are needed, and
# 2) if //content doesn't allow it, //extensions probably won't allow it.
# (see for example ui/views)
"-ui",
"+ui/base",
"+ui/gfx",
"+ui/events",
# NOTE: Please do not add includes without talking to the app shell team;
# see OWNERS for this directory.
......
include_rules = [
"+content/public/browser",
"+third_party/skia/include/core/SkRegion.h",
"+ui/aura",
"+ui/views",
]
......@@ -28,8 +28,12 @@ include_rules = [
"+storage/browser/quota",
"+sync/api",
# Disallow views to keep the binary size down.
"-ui/views",
# Additional UI dependencies for app_shell. Note that no particular UI toolkit
# is supported; only Aura and some necessary bits to set up display surfaces.
"+ui/aura",
"+ui/chromeos",
"+ui/display",
"+ui/wm",
"+third_party/cros_system_api",
......
include_rules = [
"+content/public",
"+mojo/edk/embedder",
"+ui/gl",
]
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment