Commit e2305c70 authored by Wei-Yin Chen (陳威尹)'s avatar Wei-Yin Chen (陳威尹) Committed by Commit Bot

Relax pixel diff on Pie for ReturnToChromeTest#testInitialScrollIndex

The differences in web rendering can be ignored.

Bug: 1025241
Change-Id: I7f34e51ebdd22b0be97d35ccb9257bc8387ffa8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198640Reviewed-by: default avatarYue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768880}
parent 0c234ec8
...@@ -12,6 +12,8 @@ import static org.chromium.chrome.browser.tasks.ReturnToChromeExperimentsUtil.TA ...@@ -12,6 +12,8 @@ import static org.chromium.chrome.browser.tasks.ReturnToChromeExperimentsUtil.TA
import android.app.Activity; import android.app.Activity;
import android.content.Intent; import android.content.Intent;
import android.os.Build;
import android.os.Build.VERSION_CODES;
import android.support.test.InstrumentationRegistry; import android.support.test.InstrumentationRegistry;
import android.support.test.filters.MediumTest; import android.support.test.filters.MediumTest;
import android.support.test.filters.SmallTest; import android.support.test.filters.SmallTest;
...@@ -480,6 +482,10 @@ public class ReturnToChromeTest { ...@@ -480,6 +482,10 @@ public class ReturnToChromeTest {
assertEquals(9, mActivityTestRule.getActivity().getCurrentTabModel().index()); assertEquals(9, mActivityTestRule.getActivity().getCurrentTabModel().index());
// See crbug.com/1063619 // See crbug.com/1063619
mRenderTestRule.setPixelDiffThreshold(2); mRenderTestRule.setPixelDiffThreshold(2);
if (Build.VERSION.SDK_INT == VERSION_CODES.P) {
// See crbug.com/1025241
mRenderTestRule.setPixelDiffThreshold(16);
}
// Make sure the grid tab switcher is scrolled down to show the selected tab. // Make sure the grid tab switcher is scrolled down to show the selected tab.
mRenderTestRule.render(mActivityTestRule.getActivity().findViewById( mRenderTestRule.render(mActivityTestRule.getActivity().findViewById(
org.chromium.chrome.tab_ui.R.id.tab_list_view), org.chromium.chrome.tab_ui.R.id.tab_list_view),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment