Commit e26ffff3 authored by avi's avatar avi Committed by Commit bot

Remove stl_util's deletion functions from net/url_request/.

BUG=555865

Review-Url: https://codereview.chromium.org/2385003002
Cr-Commit-Position: refs/heads/master@{#422888}
parent 909ee6ee
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
#include <utility> #include <utility>
#include "base/stl_util.h"
#include "net/base/elements_upload_data_stream.h" #include "net/base/elements_upload_data_stream.h"
#include "net/base/load_flags.h" #include "net/base/load_flags.h"
#include "net/base/request_priority.h" #include "net/base/request_priority.h"
...@@ -28,8 +27,6 @@ ReportSender::ReportSender(URLRequestContext* request_context, ...@@ -28,8 +27,6 @@ ReportSender::ReportSender(URLRequestContext* request_context,
error_callback_(error_callback) {} error_callback_(error_callback) {}
ReportSender::~ReportSender() { ReportSender::~ReportSender() {
// Cancel all of the uncompleted requests.
base::STLDeleteElements(&inflight_requests_);
} }
void ReportSender::Send(const GURL& report_uri, void ReportSender::Send(const GURL& report_uri,
...@@ -59,7 +56,7 @@ void ReportSender::Send(const GURL& report_uri, ...@@ -59,7 +56,7 @@ void ReportSender::Send(const GURL& report_uri,
ElementsUploadDataStream::CreateWithReader(std::move(reader), 0)); ElementsUploadDataStream::CreateWithReader(std::move(reader), 0));
URLRequest* raw_url_request = url_request.get(); URLRequest* raw_url_request = url_request.get();
inflight_requests_.insert(url_request.release()); inflight_requests_[raw_url_request] = std::move(url_request);
raw_url_request->Start(); raw_url_request->Start();
} }
...@@ -77,8 +74,6 @@ void ReportSender::OnResponseStarted(URLRequest* request, int net_error) { ...@@ -77,8 +74,6 @@ void ReportSender::OnResponseStarted(URLRequest* request, int net_error) {
} }
CHECK_GT(inflight_requests_.erase(request), 0u); CHECK_GT(inflight_requests_.erase(request), 0u);
// Clean up the request, which cancels it.
delete request;
} }
void ReportSender::OnReadCompleted(URLRequest* request, int bytes_read) { void ReportSender::OnReadCompleted(URLRequest* request, int bytes_read) {
......
...@@ -5,8 +5,8 @@ ...@@ -5,8 +5,8 @@
#ifndef NET_URL_REQUEST_REPORT_SENDER_H_ #ifndef NET_URL_REQUEST_REPORT_SENDER_H_
#define NET_URL_REQUEST_REPORT_SENDER_H_ #define NET_URL_REQUEST_REPORT_SENDER_H_
#include <map>
#include <memory> #include <memory>
#include <set>
#include <string> #include <string>
#include "base/callback.h" #include "base/callback.h"
...@@ -69,8 +69,7 @@ class NET_EXPORT ReportSender ...@@ -69,8 +69,7 @@ class NET_EXPORT ReportSender
CookiesPreference cookies_preference_; CookiesPreference cookies_preference_;
// Owns the contained requests. std::map<URLRequest*, std::unique_ptr<URLRequest>> inflight_requests_;
std::set<URLRequest*> inflight_requests_;
// Called when a sent report results in an error. // Called when a sent report results in an error.
ErrorCallback error_callback_; ErrorCallback error_callback_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment