Commit e27f3991 authored by Clark DuVall's avatar Clark DuVall Committed by Chromium LUCI CQ

Revert "Disable vr preload to test crash fix"

This reverts commit 49b7dc5e.

Reason for revert: This didn't fix the crash, so might as well
revert. Better crash fix coming soon...

Original change's description:
> Disable vr preload to test crash fix
>
> It looks like we are getting some crashes on VrModule.getImpl() even in
> versions where we use SplitCompatAppComponentFactory. I suspect this is
> due to the vr preload, so disabling to see if it stops crashes. If this
> works, I'll see if there's anything we can do to prevent crashing with
> the preload.
>
> Bug: 1142589
> Change-Id: I7de6c48edbb9d0a37ee271bff49295912b549d53
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611847
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840329}

TBR=agrieve@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1142589
Change-Id: I6f5f0144b74183ef57d942e5219acbd00e076c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620938Reviewed-by: default avatarClark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841933}
parent 69928ee1
......@@ -95,6 +95,8 @@ public class SplitChromeApplication extends SplitCompatApplication {
// N), the onComplete function will run immediately so it must handle the case where the
// base context of the application has not been set yet.
sSplitPreloader.preload(CHROME_SPLIT_NAME, (chromeContext) -> {
// When installed, the vr module is always loaded on startup, so preload here.
sSplitPreloader.preload("vr", null);
// If the chrome module is not enabled or isolated splits are not supported,
// chromeContext will have the same ClassLoader as the base context, so no need to
// replace the ClassLoaders here.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment