Commit e298e3bf authored by Avi Drissman's avatar Avi Drissman Committed by Commit Bot

Disable a v8_unwinder unit test

The stack sampler is broken for now on Arm Macs, so disable a failing
v8_unwinder unit test too.

Bug: 1102197, 1128464
Change-Id: Ie0091eb8efc7a96d4f917ed394585e1b6595c7d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413023Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807325}
parent 930f1996
...@@ -435,8 +435,9 @@ TEST(V8UnwinderTest, CanUnwindFrom_NullModule) { ...@@ -435,8 +435,9 @@ TEST(V8UnwinderTest, CanUnwindFrom_NullModule) {
} }
// Checks that unwinding from C++ through JavaScript and back into C++ succeeds. // Checks that unwinding from C++ through JavaScript and back into C++ succeeds.
// NB: unwinding is only supported for 64 bit Windows and OS X. // NB: unwinding is only supported for 64 bit Windows and Intel macOS.
#if (defined(OS_WIN) && defined(ARCH_CPU_64_BITS)) || defined(OS_MAC) #if (defined(OS_WIN) && defined(ARCH_CPU_64_BITS)) || \
(defined(OS_MAC) && defined(ARCH_CPU_X86_64))
#define MAYBE_UnwindThroughV8Frames UnwindThroughV8Frames #define MAYBE_UnwindThroughV8Frames UnwindThroughV8Frames
#else #else
#define MAYBE_UnwindThroughV8Frames DISABLED_UnwindThroughV8Frames #define MAYBE_UnwindThroughV8Frames DISABLED_UnwindThroughV8Frames
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment