Commit e2a338fa authored by zty's avatar zty Committed by Commit bot

Put more information into device status json output.

BUG=440939
R=navabi@chromium.org

Review URL: https://codereview.chromium.org/792183002

Cr-Commit-Position: refs/heads/master@{#308392}
parent 168b0ac2
...@@ -69,14 +69,23 @@ def DeviceInfo(serial, options): ...@@ -69,14 +69,23 @@ def DeviceInfo(serial, options):
imei_slice = _GetData(r'Device ID = (\d+)', imei_slice = _GetData(r'Device ID = (\d+)',
device_adb.old_interface.GetSubscriberInfo(), device_adb.old_interface.GetSubscriberInfo(),
lambda x: x[-6:]) lambda x: x[-6:])
json_data = {
'serial': serial,
'type': device_type,
'build': device_build,
'build_detail': device_adb.GetProp('ro.build.fingerprint'),
'battery': battery_info,
'imei_slice': imei_slice,
'wifi_ip': device_adb.GetProp('dhcp.wlan0.ipaddress'),
}
report = ['Device %s (%s)' % (serial, device_type), report = ['Device %s (%s)' % (serial, device_type),
' Build: %s (%s)' % ' Build: %s (%s)' %
(device_build, device_adb.build_fingerprint), (device_build, json_data['build_detail']),
' Current Battery Service state: ', ' Current Battery Service state: ',
'\n'.join([' %s: %s' % (k, v) '\n'.join([' %s: %s' % (k, v)
for k, v in battery_info.iteritems()]), for k, v in battery_info.iteritems()]),
' IMEI slice: %s' % imei_slice, ' IMEI slice: %s' % imei_slice,
' Wifi IP: %s' % device_adb.GetProp('dhcp.wlan0.ipaddress'), ' Wifi IP: %s' % json_data['wifi_ip'],
''] '']
errors = [] errors = []
...@@ -99,7 +108,9 @@ def DeviceInfo(serial, options): ...@@ -99,7 +108,9 @@ def DeviceInfo(serial, options):
errors += ['Mantaray device not connected to AC power.'] errors += ['Mantaray device not connected to AC power.']
full_report = '\n'.join(report) full_report = '\n'.join(report)
return device_type, device_build, battery_level, full_report, errors, dev_good
return (device_type, device_build, battery_level, full_report, errors,
dev_good, json_data)
def CheckForMissingDevices(options, adb_online_devs): def CheckForMissingDevices(options, adb_online_devs):
...@@ -319,10 +330,10 @@ def main(): ...@@ -319,10 +330,10 @@ def main():
offline_devices = android_commands.GetAttachedDevices( offline_devices = android_commands.GetAttachedDevices(
hardware=False, emulator=False, offline=True) hardware=False, emulator=False, offline=True)
types, builds, batteries, reports, errors = [], [], [], [], [] types, builds, batteries, reports, errors, json_data = [], [], [], [], [], []
fail_step_lst = [] fail_step_lst = []
if devices: if devices:
types, builds, batteries, reports, errors, fail_step_lst = ( types, builds, batteries, reports, errors, fail_step_lst, json_data = (
zip(*[DeviceInfo(dev, options) for dev in devices])) zip(*[DeviceInfo(dev, options) for dev in devices]))
err_msg = CheckForMissingDevices(options, devices) or [] err_msg = CheckForMissingDevices(options, devices) or []
...@@ -363,13 +374,7 @@ def main(): ...@@ -363,13 +374,7 @@ def main():
if options.json_output: if options.json_output:
with open(options.json_output, 'wb') as f: with open(options.json_output, 'wb') as f:
f.write(json.dumps({ f.write(json.dumps(json_data, indent=4))
'online_devices': devices,
'offline_devices': offline_devices,
'expected_devices': expected_devices,
'unique_types': unique_types,
'unique_builds': unique_builds,
}))
num_failed_devs = 0 num_failed_devs = 0
for fail_status, device in zip(fail_step_lst, devices): for fail_status, device in zip(fail_step_lst, devices):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment