Respect zero font size on <select> option and optgroup

Prior to this change, font-size:0 was ignored for <select> options and option groups. Fixed: 1102414 Change-Id: I93389cbe5258095896f6846077c9df2c18410947 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283051 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Yu Han <yuzhehan@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#785885}

Respect zero font size on <select> option and optgroup
Prior to this change, font-size:0 was ignored for <select> options and option groups. Fixed: 1102414 Change-Id: I93389cbe5258095896f6846077c9df2c18410947 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283051 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Yu Han <yuzhehan@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#785885}
e2c21044 · Mason Freed · Commit Bot · b879cc60 · e2c21044 · e2c21044
Commit e2c21044 authored Jul 07, 2020 by Mason Freed Committed by Commit Bot Jul 07, 2020
6 changed files
--- a/third_party/blink/renderer/core/html/forms/resources/listPicker.js
+++ b/third_party/blink/renderer/core/html/forms/resources/listPicker.js
@@ -444,7 +444,8 @@ ListPicker.prototype._applyItemStyle = function(element, styleConfig) {
  style.color = styleConfig.color ? styleConfig.color : '';
  style.backgroundColor =
      styleConfig.backgroundColor ? styleConfig.backgroundColor : '';
-  style.fontSize = styleConfig.fontSize ? styleConfig.fontSize + 'px' : '';
+  style.fontSize =
+      styleConfig.fontSize !== undefined ? styleConfig.fontSize + 'px' : '';
  style.fontWeight = styleConfig.fontWeight ? styleConfig.fontWeight : '';
  style.fontFamily = styleConfig.fontFamily ?
      styleConfig.fontFamily.map(s => '"' + s + '"').join(',') :

--- a/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-appearance-zero-font-size.html
+++ b/third_party/blink/web_tests/fast/forms/select-popup/popup-menu-appearance-zero-font-size.html
+<!DOCTYPE html>
+<script>
+testRunner.waitUntilDone();
+</script>
+<script src="../resources/picker-common.js"></script>
+<select id="menu">
+  <optgroup label="Theropods">
+      <option>Tyrannosaurus</option>
+      <option>Velociraptor</option>
+      <option>Deinonychus</option>
+  </optgroup>
+  <optgroup label="Sauropods">
+      <option>Diplodocus</option>
+      <option>Saltasaurus</option>
+      <option>Apatosaurus</option>
+  </optgroup>
+</select>
+<style>
+option, optgroup {
+  font-size:0;
+}
+</style>
+<script>
+openPicker(document.getElementById('menu'), () => testRunner.notifyDone(), () => testRunner.notifyDone());
+</script>
\ No newline at end of file
--- a/third_party/blink/web_tests/platform/linux/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
+++ b/third_party/blink/web_tests/platform/linux/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
--- a/third_party/blink/web_tests/platform/linux/virtual/form-controls-refresh-disabled/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
+++ b/third_party/blink/web_tests/platform/linux/virtual/form-controls-refresh-disabled/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
--- a/third_party/blink/web_tests/platform/win/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
+++ b/third_party/blink/web_tests/platform/win/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
--- a/third_party/blink/web_tests/platform/win/virtual/form-controls-refresh-disabled/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png
+++ b/third_party/blink/web_tests/platform/win/virtual/form-controls-refresh-disabled/fast/forms/select-popup/popup-menu-appearance-zero-font-size-expected.png