password_controller.js small improvements.

This CL contains 3 small cleanups.
1.Removed unused functions isAutofilled/setAutofilled (setAutofilled is used,
but isAutofilled is not used, so no reasons to keep them)
2.Removed try/catch in getPasswordFormDataList, this function is called only
for main frame or same origin iframes. So no need in try/catch. Moreover
function fillPasswordFormWithData_, which is called in the same circumstances,
doesn't have try/catch.
3.Rewritten for loop by iframes with one line with call of .some().

Bug: 782224
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I72a07181ffd643329b7217825ec182e948b3c57b
Reviewed-on: https://chromium-review.googlesource.com/825998Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524133}

ios/chrome/browser/passwords/resources/password_controller.js

@@ -51,14 +51,7 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
       return true;
     }
 
-    var frames = getSameOriginFrames_(win);
-    for (var i = 0; i < frames.length; i++) {
-      if (hasPasswordField_(frames[i])) {
-        return true;
-      }
-    }
-
-    return false;
+    return getSameOriginFrames_(win).some(hasPasswordField_);
   };
 
   /**
@@ -228,7 +221,6 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
       if (usernameInput.readOnly) {
         if (usernameInput.value == username) {
           passwordInput.value = password;
-          __gCrWeb.setAutofilled(passwordInput, true);
           filled = true;
         }
       } else {
@@ -241,8 +233,6 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
         usernameInput.value = username;
         passwordInput.focus();
         passwordInput.value = password;
-        __gCrWeb.setAutofilled(passwordInput, true);
-        __gCrWeb.setAutofilled(usernameInput, true);
         filled = true;
       }
     }
@@ -259,27 +249,6 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
     return filled;
   };
 
-  /**
-   * Returns true if the supplied field |inputElement| was autofilled.
-   * @param {Element} inputElement The form field for which we need to
-   *     acquire the autofilled indicator.
-   * @return {boolean} Whether inputElement was autofilled.
-   */
-  __gCrWeb.isAutofilled = function(inputElement) {
-    return inputElement['__gCrWebAutofilled'];
-  };
-
-  /**
-   * Marks the supplied field as autofilled or not depending on the
-   * |value|.
-   * @param {Element} inputElement The form field for which the indicator
-   *    needs to be set.
-   * @param {boolean} value The new value of the indicator.
-   */
-  __gCrWeb.setAutofilled = function(inputElement, value) {
-    inputElement['__gCrWebAutofilled'] = value;
-  };
-
   /**
    * Finds all forms with passwords in the supplied window or frame and appends
    * JS objects containing the form data to |formDataList|.
@@ -289,18 +258,7 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
    *    look for password forms.
    */
   __gCrWeb.getPasswordFormDataList = function(formDataList, win) {
-    var doc = null;
-
-    try {
-      // Security violations may generate an exception or null to be returned.
-      doc = win.document;
-    } catch(e) {
-    }
-
-    if (!doc) {
-      return;
-    }
-
+    var doc = win.document;
     var forms = doc.forms;
     for (var i = 0; i < forms.length; i++) {
       var formData = __gCrWeb.getPasswordFormData(forms[i]);