[ios] Do not call InfoBarDismissed forSaveCard banner dismissal

For most Infobars, a banner dismissal should call
InfobarDelegate::InfobarDismised(). But for SaveCard InfobarDismissed
executes the completion callback, because it assumes a dismissal
means the user closed out the UI.

Bug: 1119907
Change-Id: I91799342554041beea8efe0b2693e635f3e5a218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376451
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801609}

ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/save_card/save_card_infobar_banner_interaction_handler.h

@@ -31,6 +31,10 @@ class SaveCardInfobarBannerInteractionHandler
                                base::string16 expiration_date_month,
                                base::string16 expiration_date_year);
 
+  // Overrides InfobarBannerInteractionHandler implementation because a banner
+  // dismissal should not call InfoBarDismissed();
+  void BannerDismissedByUser(InfoBarIOS* infobar) override {}
+
  private:
   // InfobarBannerInteractionHandler:
   std::unique_ptr<InfobarBannerOverlayRequestCallbackInstaller>

ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/save_card/save_card_infobar_banner_interaction_handler_unittest.mm

@@ -60,3 +60,11 @@ TEST_F(SaveCardInfobarBannerInteractionHandlerTest, SaveCredentials) {
   handler_.SaveCredentials(infobar_.get(), cardholder_name,
                            expiration_date_month, expiration_date_year);
 }
+
+// Test that dismissing the banner does not call
+// InfobarDelegate::InfobarDismissed(), which is a behavior for the other
+// Infobars.
+TEST_F(SaveCardInfobarBannerInteractionHandlerTest, DismissalNoDelegateCall) {
+  EXPECT_CALL(mock_delegate(), InfoBarDismissed()).Times(0);
+  handler_.BannerDismissedByUser(infobar_.get());
+}

ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/test/mock_autofill_save_card_infobar_delegate_mobile.h

@@ -39,6 +39,7 @@ class MockAutofillSaveCardInfoBarDelegateMobile
                     base::string16 expiration_date_month,
                     base::string16 expiration_date_year));
   MOCK_METHOD1(OnLegalMessageLinkClicked, void(GURL url));
+  MOCK_METHOD0(InfoBarDismissed, void());
 };
 
 class MockAutofillSaveCardInfoBarDelegateMobileFactory {