Moving getElementByNameWithParent to common and simplifying.

1.getElementByNameWithParent is a generic function that's not used
 password_controller.js anymore, so common is the better place for it
(it would also allow to test it).
2.isPassword argument is not needed anymore, so function is simpified.
3.Added a test for it.

Bug: 782224
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ida9a6719f1533d36c4dd468100860046a0db809f
Reviewed-on: https://chromium-review.googlesource.com/758402
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518597}

components/autofill/ios/browser/resources/suggestion_controller.js

@@ -24,6 +24,26 @@ __gCrWeb.suggestion = {};
 // minification.
 __gCrWeb['suggestion'] = __gCrWeb.suggestion;
 
+ /**
+  * Returns the element with the specified name that is a child of the
+  * specified parent element.
+  * @param {Element} parent The parent of the desired element.
+  * @param {string} name The name of the desired element.
+  * @return {Element} The element if found, otherwise null;
+  */
+ var getElementByNameWithParent_ = function(parent, name) {
+   if (parent.name === name)
+     return parent;
+
+   var el;
+   for (var i = 0; i < parent.children.length; i++) {
+     el = getElementByNameWithParent_(parent.children[i], name);
+     if (el)
+       return el;
+   }
+   return null;
+ };
+
 /**
  * Returns the first element in |elements| that is later than |elementToCompare|
  * in tab order.
@@ -271,7 +291,7 @@ __gCrWeb.suggestion.getFormElement = function(formName, fieldName) {
   var form = __gCrWeb.common.getFormElementFromIdentifier(formName);
   if (!form)
     return null;
-  return __gCrWeb.getElementByNameWithParent(form, fieldName);
+  return getElementByNameWithParent_(form, fieldName);
 };
 
 /**

ios/chrome/browser/passwords/resources/password_controller.js

@@ -186,33 +186,6 @@ if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
         formData, username, password, window, opt_normalizedOrigin);
   };
 
-  /**
-   * Returns the element with the specified name that is a child of the
-   * specified parent element.
-   * @param {Element} parent The parent of the desired element.
-   * @param {string} name The name of the desired element.
-   * @param {boolen} isPassword Whether the field should be a password field;
-   *     if not supplied, |false| is assumed.
-   * @return {Element} The element if found, otherwise null;
-   */
-  __gCrWeb['getElementByNameWithParent'] = function(
-      parent, name, isPassword) {
-    isPassword = isPassword || false;
-    var parentType = parent.type || "";
-    var isParentPassword = parentType === "password";
-    if (parent.name === name && (isPassword === isParentPassword)) {
-      return parent;
-    }
-    for (var i = 0; i < parent.children.length; i++) {
-      var el = __gCrWeb.getElementByNameWithParent(
-          parent.children[i], name, isPassword);
-      if (el) {
-        return el;
-      }
-    }
-    return null;
-  };
-
   /**
    * Given a description of a form (origin, action and input fields),
    * finds that form on the page and fills in the specified username