Commit e302fa52 authored by Trevor  Perrier's avatar Trevor Perrier Committed by Commit Bot

Revert "[Android] Add logging for AppLocaleUtils"

This reverts commit 78a5b827.

Reason for revert: Pinpoint identified startup time increases because of this.  Need to put all logging behind flags. https://crbug.com/1134079#c6

Original change's description:
> [Android] Add logging for AppLocaleUtils
>
> This CL adds some simple logging in AppLocaleUtils to observe what
> language splits are available to the application and what the override
> locale should be.
>
> Bug: 1128698
> Change-Id: I925cd84d384602e2f0beedd63ecd551f87c24b09
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440976
> Reviewed-by: Scott Little <sclittle@chromium.org>
> Commit-Queue: Trevor  Perrier <perrier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#812522}

TBR=sclittle@chromium.org,megjablon@chromium.org,perrier@chromium.org

Change-Id: I957ab8aeb01ae21b772e332941cb95e06a7f80ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1128698, 1134079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443217Reviewed-by: default avatarTrevor  Perrier <perrier@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812898}
parent aab2fb1c
...@@ -15,7 +15,6 @@ import com.google.android.play.core.splitinstall.SplitInstallRequest; ...@@ -15,7 +15,6 @@ import com.google.android.play.core.splitinstall.SplitInstallRequest;
import org.chromium.base.BundleUtils; import org.chromium.base.BundleUtils;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
import org.chromium.chrome.browser.preferences.ChromePreferenceKeys; import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager; import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
...@@ -28,8 +27,6 @@ import java.util.Locale; ...@@ -28,8 +27,6 @@ import java.util.Locale;
public class AppLocaleUtils { public class AppLocaleUtils {
private AppLocaleUtils(){}; private AppLocaleUtils(){};
private static final String TAG = "AppLocale";
/** /**
* Return true if languageName is the same as the current application override * Return true if languageName is the same as the current application override
* language stored preference. * language stored preference.
...@@ -78,13 +75,9 @@ public class AppLocaleUtils { ...@@ -78,13 +75,9 @@ public class AppLocaleUtils {
* @param context Activity context to enable downloaded language splits on. * @param context Activity context to enable downloaded language splits on.
*/ */
public static void maybeInstallActivitySplitCompat(Context context) { public static void maybeInstallActivitySplitCompat(Context context) {
Log.i(TAG, "maybeInstallActivitySplit isOverridden: %s isBundle: %s",
GlobalAppLocaleController.getInstance().isOverridden(), BundleUtils.isBundle());
if (GlobalAppLocaleController.getInstance().isOverridden() && BundleUtils.isBundle()) { if (GlobalAppLocaleController.getInstance().isOverridden() && BundleUtils.isBundle()) {
SplitCompat.installActivity(context); SplitCompat.installActivity(context);
Log.i(TAG, "Override Locale: %s", getAppLanguagePref());
} }
logInstalledLanguages();
} }
/** /**
...@@ -102,21 +95,5 @@ public class AppLocaleUtils { ...@@ -102,21 +95,5 @@ public class AppLocaleUtils {
.build(); .build();
splitInstallManager.startInstall(installRequest); splitInstallManager.startInstall(installRequest);
} }
logInstalledLanguages();
}
/**
* Log list of installed languages
*/
private static void logInstalledLanguages() {
if (BundleUtils.isBundle()) {
SplitInstallManager splitInstallManager =
SplitInstallManagerFactory.create(ContextUtils.getApplicationContext());
Log.i(TAG, "Installed Languages: %s",
TextUtils.join(", ", splitInstallManager.getInstalledLanguages()));
} else {
Log.i(TAG, "Installed Languages: None - not a bundle");
}
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment