Commit e32020ec authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

Fix use of deprecated BooleanValue in content/shell

Bug: v8:7279, v8:8238
Change-Id: I0dc237e75557470d38d670cefe760f19378a5740
Reviewed-on: https://chromium-review.googlesource.com/c/1349338Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610584}
parent 04d576b4
......@@ -102,18 +102,7 @@ void ConvertAndSet(gin::Arguments* args, int* set_param) {
void ConvertAndSet(gin::Arguments* args, bool* set_param) {
v8::Local<v8::Value> value = args->PeekNext();
v8::Maybe<bool> result =
value->BooleanValue(args->GetHolderCreationContext());
if (result.IsNothing()) {
// Skip so the error is thrown for the correct argument as PeekNext doesn't
// update the current argument pointer.
args->Skip();
args->ThrowError();
return;
}
*set_param = result.ToChecked();
*set_param = value->BooleanValue(args->isolate());
}
void ConvertAndSet(gin::Arguments* args, blink::WebString* set_param) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment