Commit e3203220 authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

base: refactor ImmediateCrashTest.ExpectedOpcodeSequence

This change refactors this test by:
1) Splitting out the library & bytecode-snarfing logic to a helper
   function
2) Deduplicating some code that existed on each platform, via use of
   a couple of typedefs
3) Has the test not hang onto the shared library if one of the gtest
   asserts fail - I don't think this is a problem in practice, but.

Bug: None
Change-Id: Iea33973b141de7cb5fe1aaeae5eb1d6773d31c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414684Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810407}
parent 64875586
...@@ -3219,6 +3219,12 @@ test("base_unittests") { ...@@ -3219,6 +3219,12 @@ test("base_unittests") {
"strings/sys_string_conversions_mac_unittest.mm", "strings/sys_string_conversions_mac_unittest.mm",
] ]
sources -= [
# The immediate crash tests require shared libraries, which we don't
# support loading on iOS.
"immediate_crash_unittest.cc",
]
if (use_allocator_shim) { if (use_allocator_shim) {
sources += [ sources += [
"allocator/allocator_interception_mac_unittest.mm", "allocator/allocator_interception_mac_unittest.mm",
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment