Commit e3539906 authored by Tommy Nyquist's avatar Tommy Nyquist Committed by Commit Bot

[Android] Disable most translate intent tests.

These tests were previously failing only on Marshmallow, but are now
failing on Lollipop, and Pie as well.

Bug: 1127786, 1135682
Change-Id: Ib6c49f8ffa6997568fa74171b293e1bcfc41b7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453497Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814374}
parent ecd194cf
...@@ -8,7 +8,6 @@ import android.content.ComponentName; ...@@ -8,7 +8,6 @@ import android.content.ComponentName;
import android.content.Context; import android.content.Context;
import android.content.Intent; import android.content.Intent;
import android.content.pm.PackageManager; import android.content.pm.PackageManager;
import android.os.Build.VERSION_CODES;
import androidx.test.filters.MediumTest; import androidx.test.filters.MediumTest;
import androidx.test.filters.SmallTest; import androidx.test.filters.SmallTest;
...@@ -25,7 +24,7 @@ import org.junit.runner.RunWith; ...@@ -25,7 +24,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.test.util.Batch; import org.chromium.base.test.util.Batch;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf; import org.chromium.base.test.util.DisabledTest;
import org.chromium.chrome.browser.IntentHandler; import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.document.ChromeLauncherActivity; import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.flags.ChromeFeatureList; import org.chromium.chrome.browser.flags.ChromeFeatureList;
...@@ -136,9 +135,7 @@ public class TranslateIntentTest { ...@@ -136,9 +135,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.DisableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.DisableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentDisabled() throws TimeoutException { testTranslateIntentDisabled() throws TimeoutException {
...@@ -156,9 +153,7 @@ public class TranslateIntentTest { ...@@ -156,9 +153,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentOnTranslatePage() throws TimeoutException { testTranslateIntentOnTranslatePage() throws TimeoutException {
...@@ -176,9 +171,7 @@ public class TranslateIntentTest { ...@@ -176,9 +171,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentOnNonTranslatePage() throws TimeoutException { testTranslateIntentOnNonTranslatePage() throws TimeoutException {
...@@ -198,9 +191,7 @@ public class TranslateIntentTest { ...@@ -198,9 +191,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentWithTargetLanguage() throws TimeoutException, ExecutionException { testTranslateIntentWithTargetLanguage() throws TimeoutException, ExecutionException {
...@@ -229,9 +220,7 @@ public class TranslateIntentTest { ...@@ -229,9 +220,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentWithUnsupportedTargetLanguage() throws TimeoutException { testTranslateIntentWithUnsupportedTargetLanguage() throws TimeoutException {
...@@ -249,9 +238,7 @@ public class TranslateIntentTest { ...@@ -249,9 +238,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentOnIncognito() throws TimeoutException { testTranslateIntentOnIncognito() throws TimeoutException {
...@@ -273,9 +260,7 @@ public class TranslateIntentTest { ...@@ -273,9 +260,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentWithUrlMismatch() throws TimeoutException { testTranslateIntentWithUrlMismatch() throws TimeoutException {
...@@ -293,9 +278,7 @@ public class TranslateIntentTest { ...@@ -293,9 +278,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentWithoutExpectedUrl() throws TimeoutException { testTranslateIntentWithoutExpectedUrl() throws TimeoutException {
...@@ -313,9 +296,7 @@ public class TranslateIntentTest { ...@@ -313,9 +296,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentVerifyComponent() throws TimeoutException { testTranslateIntentVerifyComponent() throws TimeoutException {
...@@ -339,9 +320,7 @@ public class TranslateIntentTest { ...@@ -339,9 +320,7 @@ public class TranslateIntentTest {
@Test @Test
@MediumTest @MediumTest
@DisableIf. @DisabledTest(message = "https://crbug.com/1127786 and https://crbug.com/1135682")
Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1, sdk_is_less_than = VERSION_CODES.N,
message = "Consistently failing on Marshmallow https://crbug.com/1127786")
@Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT}) @Features.EnableFeatures({ChromeFeatureList.TRANSLATE_INTENT})
public void public void
testTranslateIntentIncorrectComponent() throws TimeoutException { testTranslateIntentIncorrectComponent() throws TimeoutException {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment