Commit e36cc582 authored by Mounir Lamouri's avatar Mounir Lamouri Committed by Commit Bot

Sheriff: Disable flaky WebRTC on ASan builds.

Bug: 898546
Change-Id: I18f631b57d17eb9750ec37b1e7a00fa0d7d3cbea
TBR: yvesg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1349450
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610660}
parent a017650b
...@@ -122,12 +122,20 @@ class WebRtcBrowserTest : public WebRtcTestBase { ...@@ -122,12 +122,20 @@ class WebRtcBrowserTest : public WebRtcTestBase {
content::WebContents* right_tab_; content::WebContents* right_tab_;
}; };
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, // TODO(898546): many of these tests are failing on ASan builds.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_WebRtcBrowserTest DISABLED_WebRtcBrowserTest
class DISABLED_WebRtcBrowserTest : public WebRtcBrowserTest {};
#else
#define MAYBE_WebRtcBrowserTest WebRtcBrowserTest
#endif
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsVP8) { RunsAudioVideoWebRTCCallInTwoTabsVP8) {
RunsAudioVideoWebRTCCallInTwoTabs("VP8"); RunsAudioVideoWebRTCCallInTwoTabs("VP8");
} }
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsVP9) { RunsAudioVideoWebRTCCallInTwoTabsVP9) {
RunsAudioVideoWebRTCCallInTwoTabs("VP9"); RunsAudioVideoWebRTCCallInTwoTabs("VP9");
} }
...@@ -172,14 +180,14 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, TestWebAudioMediaStream) { ...@@ -172,14 +180,14 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, TestWebAudioMediaStream) {
ASSERT_FALSE(tab->IsCrashed()); ASSERT_FALSE(tab->IsCrashed());
} }
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa) { RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa) {
RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec, RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec,
false /* prefer_hw_video_codec */, false /* prefer_hw_video_codec */,
kKeygenAlgorithmRsa, kKeygenAlgorithmRsa); kKeygenAlgorithmRsa, kKeygenAlgorithmRsa);
} }
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsOfferEcdsaAnswerEcdsa) { RunsAudioVideoWebRTCCallInTwoTabsOfferEcdsaAnswerEcdsa) {
RunsAudioVideoWebRTCCallInTwoTabs( RunsAudioVideoWebRTCCallInTwoTabs(
WebRtcTestBase::kUseDefaultVideoCodec, false /* prefer_hw_video_codec */, WebRtcTestBase::kUseDefaultVideoCodec, false /* prefer_hw_video_codec */,
...@@ -187,32 +195,32 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, ...@@ -187,32 +195,32 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
} }
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
WebRtcBrowserTest, MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificateRsa) { RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificateRsa) {
RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificate(kKeygenAlgorithmRsa); RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificate(kKeygenAlgorithmRsa);
} }
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
WebRtcBrowserTest, MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificateEcdsa) { RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificateEcdsa) {
RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificate(kKeygenAlgorithmEcdsa); RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificate(kKeygenAlgorithmEcdsa);
} }
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerEcdsa) { RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerEcdsa) {
RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec, RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec,
false /* prefer_hw_video_codec */, false /* prefer_hw_video_codec */,
kKeygenAlgorithmRsa, kKeygenAlgorithmEcdsa); kKeygenAlgorithmRsa, kKeygenAlgorithmEcdsa);
} }
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsOfferEcdsaAnswerRsa) { RunsAudioVideoWebRTCCallInTwoTabsOfferEcdsaAnswerRsa) {
RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec, RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec,
false /* prefer_hw_video_codec */, false /* prefer_hw_video_codec */,
kKeygenAlgorithmEcdsa, kKeygenAlgorithmRsa); kKeygenAlgorithmEcdsa, kKeygenAlgorithmRsa);
} }
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback) { RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback) {
StartServerAndOpenTabs(); StartServerAndOpenTabs();
SetupPeerconnectionWithLocalStream(left_tab_); SetupPeerconnectionWithLocalStream(left_tab_);
...@@ -224,15 +232,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, ...@@ -224,15 +232,8 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
DetectVideoAndHangUp(); DetectVideoAndHangUp();
} }
#if defined(OS_LINUX) && defined(ADDRESS_SANITIZER) IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
#define MAYBE_RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise \ RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise) {
DISABLED_RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise
#else
#define MAYBE_RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise \
RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise
#endif
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
MAYBE_RunsAudioVideoWebRTCCallInTwoTabsGetStatsPromise) {
StartServerAndOpenTabs(); StartServerAndOpenTabs();
SetupPeerconnectionWithLocalStream(left_tab_); SetupPeerconnectionWithLocalStream(left_tab_);
SetupPeerconnectionWithLocalStream(right_tab_); SetupPeerconnectionWithLocalStream(right_tab_);
...@@ -255,7 +256,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, ...@@ -255,7 +256,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
} }
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
WebRtcBrowserTest, MAYBE_WebRtcBrowserTest,
RunsAudioVideoWebRTCCallInTwoTabsEmitsGatheringStateChange) { RunsAudioVideoWebRTCCallInTwoTabsEmitsGatheringStateChange) {
StartServerAndOpenTabs(); StartServerAndOpenTabs();
SetupPeerconnectionWithLocalStream(left_tab_); SetupPeerconnectionWithLocalStream(left_tab_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment