Use a different color to highlight nodes rendered by LayoutNG.

With this patch, a node rendered by LayoutNG will be highlighted with
a different color when you hover over the node in the inspector.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I648d7cfa6bfd93a7829ffb480fe029b7e64a67c9
Reviewed-on: https://chromium-review.googlesource.com/1158391
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580508}

third_party/blink/renderer/core/inspector/inspector_highlight.cc

@@ -19,6 +19,7 @@
 #include "third_party/blink/renderer/core/page/page.h"
 #include "third_party/blink/renderer/core/style/computed_style_constants.h"
 #include "third_party/blink/renderer/platform/graphics/path.h"
+#include "third_party/blink/renderer/platform/layout_test_support.h"
 
 namespace blink {
 
@@ -418,11 +419,17 @@ void InspectorHighlight::AppendNodeHighlight(
   if (!layout_object)
     return;
 
+  // Just for testing, invert the content color for nodes rendered by LayoutNG.
+  // TODO(layout-dev): Stop munging the color before NG ships. crbug.com/869866
+  Color content_color = layout_object->IsLayoutNGObject() &&
+                                !LayoutTestSupport::IsRunningLayoutTest()
+                            ? Color(highlight_config.content.Rgb() ^ 0x00ffffff)
+                            : highlight_config.content;
+
   Vector<FloatQuad> svg_quads;
   if (BuildSVGQuads(node, svg_quads)) {
     for (size_t i = 0; i < svg_quads.size(); ++i) {
-      AppendQuad(svg_quads[i], highlight_config.content,
-                 highlight_config.content_outline);
+      AppendQuad(svg_quads[i], content_color, highlight_config.content_outline);
     }
     return;
   }
@@ -430,8 +437,8 @@ void InspectorHighlight::AppendNodeHighlight(
   FloatQuad content, padding, border, margin;
   if (!BuildNodeQuads(node, &content, &padding, &border, &margin))
     return;
-  AppendQuad(content, highlight_config.content,
-             highlight_config.content_outline, "content");
+  AppendQuad(content, content_color, highlight_config.content_outline,
+             "content");
   AppendQuad(padding, highlight_config.padding, Color::kTransparent, "padding");
   AppendQuad(border, highlight_config.border, Color::kTransparent, "border");
   AppendQuad(margin, highlight_config.margin, Color::kTransparent, "margin");

third_party/blink/renderer/core/layout/layout_object.h

@@ -619,6 +619,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
   virtual bool IsLayoutFlowThread() const { return false; }
   virtual bool IsLayoutInline() const { return false; }
   virtual bool IsLayoutEmbeddedContent() const { return false; }
+  virtual bool IsLayoutNGObject() const { return false; }
 
   bool IsDocumentElement() const {
     return GetDocument().documentElement() == node_;

third_party/blink/renderer/core/layout/ng/inline/layout_ng_text.h

@@ -26,6 +26,7 @@ class CORE_EXPORT LayoutNGText : public LayoutText {
   bool IsOfType(LayoutObjectType type) const override {
     return type == kLayoutObjectNGText || LayoutText::IsOfType(type);
   }
+  bool IsLayoutNGObject() const override { return true; }
 
   bool HasValidLayout() const { return valid_ng_items_; }
   const Vector<NGInlineItem*>& InlineItems() const {

third_party/blink/renderer/core/layout/ng/layout_ng_flexible_box.h

@@ -18,6 +18,7 @@ class CORE_EXPORT LayoutNGFlexibleBox : public LayoutBlock {
   void UpdateBlockLayout(bool relayout_children) override;
 
   bool IsFlexibleBox() const final { return true; }
+  bool IsLayoutNGObject() const override { return true; }
   const char* GetName() const override { return "LayoutNGFlexibleBox"; }
 
  protected:

third_party/blink/renderer/core/layout/ng/layout_ng_mixin.h

@@ -30,6 +30,8 @@ class LayoutNGMixin : public Base {
   explicit LayoutNGMixin(Element* element);
   ~LayoutNGMixin() override;
 
+  bool IsLayoutNGObject() const override { return true; }
+
   NGInlineNodeData* TakeNGInlineNodeData() override;
   NGInlineNodeData* GetNGInlineNodeData() const override;
   void ResetNGInlineNodeData() override;

third_party/blink/renderer/core/layout/ng/list/layout_ng_list_item.h

@@ -26,6 +26,7 @@ class CORE_EXPORT LayoutNGListItem final : public LayoutNGBlockFlow {
     return StyleRef().ListStyleImage() &&
            !StyleRef().ListStyleImage()->ErrorOccurred();
   }
+  bool IsLayoutNGObject() const override { return true; }
 
   void UpdateMarkerTextIfNeeded() {
     if (marker_ && !is_marker_text_updated_ && !IsMarkerImage())

third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h

@@ -33,6 +33,8 @@ class CORE_EXPORT LayoutNGListMarker final
 
   bool IsContentImage() const;
 
+  bool IsLayoutNGObject() const override { return true; }
+
   LayoutObject* SymbolMarkerLayoutText() const;
 
   // Marker text with suffix, e.g. "1. ", for use in accessibility.

third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker_image.h

@@ -17,6 +17,8 @@ class CORE_EXPORT LayoutNGListMarkerImage final : public LayoutImage {
   explicit LayoutNGListMarkerImage(Element*);
   static LayoutNGListMarkerImage* CreateAnonymous(Document*);
 
+  bool IsLayoutNGObject() const override { return true; }
+
  private:
   bool IsOfType(LayoutObjectType) const override;