Commit e384a3e2 authored by Dean Michael Berris's avatar Dean Michael Berris Committed by Commit Bot

chromeperf: Set no symbols for perf builds

This change reduces the size of the isolates generated for builds
on all platforms by only generating minimal symbols useful for
generating stack traces.

What we lose are the following:

- Full fidelity for core dumps in perf builds.

- Full debug information when stepping through a perf build.

What we gain though is much smaller binaries to download and test with.

R=agable@chromium.org, johnchen@chromium.org

Bug: chromium:1076723
Change-Id: Idd5198fe2a7afb9121c76bc1583a824174b8e737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174105
Commit-Queue: Dean Berris <dberris@chromium.org>
Auto-Submit: Dean Berris <dberris@chromium.org>
Reviewed-by: default avatarAaron Gable <agable@chromium.org>
Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765419}
parent b378fc87
......@@ -509,18 +509,18 @@
'win-asan': 'asan_clang_fuzzer_static_v8_heap_minimal_symbols_release',
},
'chromium.perf': {
'chrome.perf': {
'Android Builder Perf': 'official_goma_minimal_symbols_android',
'Android arm64 Builder Perf': 'official_goma_minimal_symbols_android_arm64',
'android_arm64-builder-perf': 'official_goma_minimal_symbols_android_arm64',
'android-builder-perf': 'official_goma_minimal_symbols_android',
'linux-builder-perf': 'official_goma_perf',
'linux-builder-perf': 'official_goma_linux_perf',
'mac-builder-perf': 'official_goma_mac_perf',
'win32-builder-perf': 'official_goma_x86',
'win64-builder-perf': 'official_goma',
'win32-builder-perf': 'official_goma_x86_perf',
'win64-builder-perf': 'official_goma_perf',
},
'chromium.perf.fyi': {
'chrome.perf.fyi': {
'android-cfi-builder-perf-fyi': 'official_goma_minimal_symbols_android_thin_lto_opt',
'android_arm64-cfi-builder-perf-fyi': 'official_goma_minimal_symbols_android_thin_lto_opt_arm64',
'chromeos-kevin-builder-perf-fyi': 'chromeos_kevin',
......@@ -931,13 +931,13 @@
'mac-rel': 'gpu_tests_release_trybot_deterministic_mac',
},
'tryserver.chromium.perf': {
'tryserver.chrome.perf': {
'Android Compile Perf': 'official_goma_minimal_symbols_android',
'Android arm64 Compile Perf': 'official_goma_minimal_symbols_android_arm64',
'Linux Builder Perf': 'official_goma_perf',
'Linux Builder Perf': 'official_goma_linux_perf',
'Mac Builder Perf': 'official_goma_mac_perf',
'Win Builder Perf': 'official_goma_x86',
'Win x64 Builder Perf': 'official_goma',
'Win Builder Perf': 'official_goma_x86_perf',
'Win x64 Builder Perf': 'official_goma_perf',
},
'tryserver.chromium.swangle': {
......@@ -1987,16 +1987,20 @@
'official', 'goma',
],
'official_goma_perf': [
'official', 'goma', 'no_symbols',
],
'official_goma_mac_perf': [
'official', 'goma', 'no_keystone_registration_framework',
'official', 'goma', 'no_keystone_registration_framework', 'no_symbols',
],
'official_goma_mac_pgo': [
'official', 'goma', 'no_keystone_registration_framework', 'static', 'no_symbols', 'pgo_phase_1'
],
'official_goma_perf': [
'official', 'goma', 'no_gnome_keyring',
'official_goma_linux_perf': [
'official', 'goma', 'no_gnome_keyring', 'no_symbols',
],
'official_goma_chromeos': [
......@@ -2035,6 +2039,10 @@
'official', 'goma', 'x86',
],
'official_goma_x86_perf': [
'official', 'goma', 'x86', 'no_symbols'
],
'official_goma_x86_pgo': [
'official', 'goma', 'x86', 'static', 'no_symbols', 'pgo_phase_1', 'no_resource_whitelisting',
],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment