Commit e39a824f authored by Guido Urdaneta's avatar Guido Urdaneta Committed by Commit Bot

Update WebRtcGetUserMediaBrowserTest.ApplyConstraintsVideoTwoStreams

Use exact constraints and explicit values in order to reduce the
probability of flakes.

Bug: 1055012
Change-Id: I5b232694710c90682c9e143895af9979a400d858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336076Reviewed-by: default avatarMarina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794989}
parent 7fbc5304
...@@ -689,39 +689,41 @@ ...@@ -689,39 +689,41 @@
} }
function applyConstraintsVideoTwoStreams() { function applyConstraintsVideoTwoStreams() {
navigator.mediaDevices.getUserMedia({video:true}) navigator.mediaDevices.getUserMedia({
.then(stream => { video:{
width:{exact:640},
height: {exact:480}
}
}).then(stream => {
assertEquals(stream.getVideoTracks().length, 1); assertEquals(stream.getVideoTracks().length, 1);
var track1 = stream.getVideoTracks()[0]; let track1 = stream.getVideoTracks()[0];
let deviceId1 = track1.getSettings().deviceId;
track1.onmute = () => failTest("Unexpected mute of track1"); track1.onmute = () => failTest("Unexpected mute of track1");
track1.onunmute = () => failTest("Unexpected unmute of track1"); track1.onunmute = () => failTest("Unexpected unmute of track1");
var settings1 = track1.getSettings(); return navigator.mediaDevices.getUserMedia({
var default_device_id = settings1.deviceId; video:{
var default_width = settings1.width; deviceId: {exact: deviceId1},
var default_height = settings1.height; width:{exact:640},
return navigator.mediaDevices.getUserMedia({video:true}) height: {exact:480}
.then(stream2 => { }
var track2 = stream2.getVideoTracks()[0]; }).then(stream2 => {
let track2 = stream2.getVideoTracks()[0];
track2.onmute = () => failTest("Unexpected mute of track2"); track2.onmute = () => failTest("Unexpected mute of track2");
track2.onunmute = () => failTest("Unexpected unmute of track2"); track2.onunmute = () => failTest("Unexpected unmute of track2");
var settings2 = track2.getSettings();
assertEquals(settings2.width, default_width);
assertEquals(settings2.height, default_height);
assertEquals(settings2.deviceId, default_device_id);
return track1.applyConstraints({ return track1.applyConstraints({
width: default_width-1, width: {exact: 639},
height: default_height-1 height: {exact: 479}
}).then(()=> { }).then(()=> {
assertEquals(track1.readyState, "live"); assertEquals(track1.readyState, "live");
settings1 = track1.getSettings(); let settings1 = track1.getSettings();
assertEquals(settings1.deviceId, default_device_id); assertEquals(639, settings1.width);
assertEquals(settings1.width, default_width - 1); assertEquals(479, settings1.height);
assertEquals(settings1.height, default_height - 1);
assertEquals(track2.readyState, "live"); assertEquals(track2.readyState, "live");
settings2 = track2.getSettings(); let settings2 = track2.getSettings();
assertEquals(settings2.deviceId, default_device_id); assertEquals(640, settings2.width);
assertEquals(settings2.width, default_width); assertEquals(480, settings2.height);
assertEquals(settings2.height, default_height); assertEquals(deviceId1, settings1.deviceId);
assertEquals(deviceId1, settings2.deviceId);
track1.stop(); track1.stop();
track2.stop(); track2.stop();
reportTestSuccess(); reportTestSuccess();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment