Commit e39b6fce authored by Clark DuVall's avatar Clark DuVall Committed by Chromium LUCI CQ

Split out a minimal target from content_java to use in the base module

This reduces the base dex size in trichrome by 0.5MB, which should help
both memory usage and startup time in child processes with isolated
splits enabled. Unfortunately we can't do the same for monochrome at the
moment because WebView still needs the full content_java target.

Bug: 11674041
Change-Id: I2aa3ba17ef97ab311e23f3ab8f0c0340cee9bfe7
Binary-Size: The method count is inflated because methods are moving
Binary-Size: from the base module -> chrome module, and it doesn't look
Binary-Size: like these are counted right. The increase in
Binary-Size: Combined_unique methods is only +13.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634009
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844827}
parent 27f8a051
......@@ -2228,7 +2228,8 @@ android_library("base_module_java") {
"//components/version_info/android:version_constants_java",
"//components/viz/common:common_java",
"//components/viz/service:service_java",
"//content/public/android:content_java",
"//content/public/android:content_main_dex_java",
"//media/base/android:media_java",
# Deps for DFMs.
"//chrome/android/modules/extra_icu/provider:java",
......@@ -2251,6 +2252,10 @@ android_library("base_module_java") {
srcjar_deps = [ ":chrome_product_config" ]
# If this throws an error, try depending on
# //content/public/android:content_main_dex_java instead.
assert_no_deps = [ "//content/public/android:content_full_java" ]
# Add the actual implementation where necessary so that downstream targets
# can provide their own implementations.
jar_excluded_patterns = [ "*/ProductConfig.class" ]
......
......@@ -16,7 +16,7 @@ android_library("file_provider_java") {
deps = [
"//base:base_java",
"//components/embedder_support/android:util_java",
"//content/public/android:content_java",
"//content/public/android:content_main_dex_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
"//third_party/android_deps:androidx_core_core_java",
]
......
......@@ -20,7 +20,6 @@ android_library("java") {
"//base:jni_java",
"//components/browser_ui/util/android:java",
"//components/embedder_support/android:util_java",
"//content/public/android:content_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
"//third_party/android_deps:androidx_core_core_java",
"//ui/android:ui_full_java",
......
......@@ -84,7 +84,7 @@ if (is_android) {
deps = [
":background_task_scheduler_task_ids_java",
"//base:base_java",
"//content/public/android:content_java",
"//content/public/android:content_main_dex_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
]
}
......
......@@ -34,7 +34,7 @@ if (is_android) {
"//base:base_java",
"//components/background_task_scheduler:background_task_scheduler_task_ids_java",
"//components/background_task_scheduler:public_java",
"//content/public/android:content_java",
"//content/public/android:content_main_dex_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
"//third_party/android_deps:chromium_play_services_availability_java",
"//third_party/android_deps:protobuf_lite_runtime_java",
......
......@@ -23,7 +23,6 @@ android_library("java") {
"//base:base_java",
"//cc:cc_java",
"//components/embedder_support/android:util_java",
"//content/public/android:content_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
"//third_party/android_deps:androidx_collection_collection_java",
"//third_party/android_deps:androidx_core_core_java",
......
......@@ -49,7 +49,7 @@ android_library("util_java") {
"//base:base_java",
"//base:jni_java",
"//components/url_formatter/android:url_formatter_java",
"//content/public/android:content_java",
"//content/public/android:content_main_dex_java",
"//net/android:net_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
"//third_party/android_deps:androidx_core_core_java",
......
......@@ -112,7 +112,7 @@ android_library("service_java") {
"//base:base_java",
"//base:jni_java",
"//components/payments/mojom:mojom_java",
"//content/public/android:content_java",
"//content/public/android:content_main_dex_java",
"//third_party/android_deps:androidx_annotation_annotation_java",
]
srcjar_deps = [
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment