Commit e3c649ed authored by Shakti Sahu's avatar Shakti Sahu Committed by Commit Bot

Video Tutorials : Remove loading animation

This CL removes the loading animation for the video player. We will use
chrome media's in-built loading animation for this purpose which also
provides better feedback on slow networks and other video failures.

Bug: 1149946
Change-Id: Ib0e7ad4ab131e10e0bda01e819bb7314ec6d57b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542860Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828372}
parent f8a52df9
......@@ -194,7 +194,7 @@ class VideoPlayerMediator implements PlaybackStateObserver.Observer {
new LoadUrlParams(VideoPlayerURLBuilder.buildFromTutorial(tutorial));
loadUrlParams.setHasUserGesture(true);
mWebContents.getNavigationController().loadUrl(loadUrlParams);
mModel.set(VideoPlayerProperties.SHOW_LOADING_SCREEN, true);
mModel.set(VideoPlayerProperties.SHOW_LOADING_SCREEN, false);
mModel.set(VideoPlayerProperties.SHOW_MEDIA_CONTROLS, false);
}
......
......@@ -116,7 +116,7 @@ public class VideoPlayerMediatorUnitTest {
Tutorial tutorial = mTestVideoTutorialService.getTestTutorials().get(0);
mMediator.playVideoTutorial(tutorial);
Mockito.verify(mNavigationController).loadUrl(any());
assertThat(mModel.get(VideoPlayerProperties.SHOW_LOADING_SCREEN), equalTo(true));
assertThat(mModel.get(VideoPlayerProperties.SHOW_LOADING_SCREEN), equalTo(false));
assertThat(mModel.get(VideoPlayerProperties.SHOW_MEDIA_CONTROLS), equalTo(false));
mMediator.onPlay();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment