Commit e3f30d15 authored by Jun Mukai's avatar Jun Mukai Committed by Commit Bot

fix enrollment UMA

Noticed that the enrollment UMA will be invoked through the
enrollment flow for offline demo mode. At least it shouldn't be
NOTREACHED(). Considering the situation, I believe it can be
handled as other normal enrollment.

BUG=835904
TEST=manually

Change-Id: I61d50258429f3c72132c29d58a6208736756e3d8
Reviewed-on: https://chromium-review.googlesource.com/1092092Reviewed-by: default avatarAga Wronska <agawronska@chromium.org>
Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569374}
parent 73269d6d
...@@ -25,6 +25,7 @@ void EnrollmentUMA(policy::MetricEnrollment sample, ...@@ -25,6 +25,7 @@ void EnrollmentUMA(policy::MetricEnrollment sample,
case policy::EnrollmentConfig::MODE_LOCAL_ADVERTISED: case policy::EnrollmentConfig::MODE_LOCAL_ADVERTISED:
case policy::EnrollmentConfig::MODE_SERVER_ADVERTISED: case policy::EnrollmentConfig::MODE_SERVER_ADVERTISED:
case policy::EnrollmentConfig::MODE_ATTESTATION: case policy::EnrollmentConfig::MODE_ATTESTATION:
case policy::EnrollmentConfig::MODE_OFFLINE_DEMO:
base::UmaHistogramSparse(kMetricEnrollment, sample); base::UmaHistogramSparse(kMetricEnrollment, sample);
break; break;
case policy::EnrollmentConfig::MODE_LOCAL_FORCED: case policy::EnrollmentConfig::MODE_LOCAL_FORCED:
...@@ -37,13 +38,6 @@ void EnrollmentUMA(policy::MetricEnrollment sample, ...@@ -37,13 +38,6 @@ void EnrollmentUMA(policy::MetricEnrollment sample,
case policy::EnrollmentConfig::MODE_RECOVERY: case policy::EnrollmentConfig::MODE_RECOVERY:
base::UmaHistogramSparse(kMetricEnrollmentRecovery, sample); base::UmaHistogramSparse(kMetricEnrollmentRecovery, sample);
break; break;
case policy::EnrollmentConfig::MODE_OFFLINE_DEMO:
// MODE_OFFLINE_DEMO is currently NOTREACHED(), since the normal
// enrollment flow (which invokes this function) shouldn't use this mode.
// TODO(mukai, agawronska): decide what needs to be done here.
// https://crbug.com/835904
NOTREACHED();
break;
case policy::EnrollmentConfig::MODE_NONE: case policy::EnrollmentConfig::MODE_NONE:
NOTREACHED(); NOTREACHED();
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment