Print Preview: Convert "Manage" link to a link from action-link

This no longer needs to be an action-link, since it is not opening
native dialogs or going through the C++ handler to correctly open cloud
print URLs with the correct user information. Instead, it is always
opening the chrome://settings printing page. This can be handled more
simply by using a normal link.

Bug: None
Change-Id: I9375ae0ac0c936aec379270f79f6130d054c1dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1278527Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599273}

chrome/browser/resources/print_preview/native_layer.js

@@ -272,6 +272,7 @@ cr.define('print_preview', function() {
     /**
      * Navigates the user to the Chrome printing setting page to manage local
      * printers and Google cloud printers.
+     * TODO (rbpotter): Delete this when the old Print Preview page is removed.
      */
     managePrinters() {
       chrome.send('managePrinters');

chrome/browser/resources/print_preview/new/BUILD.gn

@@ -308,7 +308,6 @@ js_library("destination_dialog") {
 js_library("destination_list") {
   deps = [
     ":destination_list_item",
-    "..:native_layer",
     "../data:destination",
     "//ui/webui/resources/js:i18n_behavior",
     "//ui/webui/resources/js:list_property_update_behavior",

chrome/browser/resources/print_preview/new/destination_dialog.html

@@ -181,7 +181,7 @@
         </print-preview-destination-list>
         <print-preview-destination-list id="printList"
             destinations="[[destinations_]]"
-            has-action-link loading-destinations="[[loadingDestinations_]]"
+            has-manage-link loading-destinations="[[loadingDestinations_]]"
             search-query="[[searchQuery_]]"
             list-name="$i18n{printDestinationsTitle}"
             on-destination-selected="onDestinationSelected_">

chrome/browser/resources/print_preview/new/destination_list.html

@@ -2,12 +2,9 @@
 
 <link rel="import" href="chrome://resources/cr_elements/hidden_style_css.html">
 <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
-<link rel="import" href="chrome://resources/html/action_link.html">
-<link rel="import" href="chrome://resources/html/action_link_css.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/list_property_update_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">
-<link rel="import" href="../native_layer.html">
 <link rel="import" href="../data/destination.html">
 <link rel="import" href="destination_list_item.html">
 <link rel="import" href="print_preview_shared_css.html">
@@ -16,7 +13,7 @@
 
 <dom-module id="print-preview-destination-list">
   <template>
-    <style include="print-preview-shared action-link cr-hidden-style throbber">
+    <style include="print-preview-shared cr-hidden-style throbber">
       :host {
         display: flex;
         flex-direction: column;
@@ -45,12 +42,12 @@
         padding-bottom: 8px;
       }
 
-      :-webkit-any(.action-link, .total) {
+      :-webkit-any(.link, .total) {
         display: inline;
         padding: 0 4px;
       }
 
-      .action-link {
+      .link {
         margin: 0 2px;
       }
 
@@ -91,8 +88,8 @@
       <span class="total" hidden$="[[!showDestinationsTotal_]]">
         [[i18n('destinationCount', matchingDestinations_.length)]]
       </span>
-      <a is="action-link" class="action-link" hidden$="[[!hasActionLink]]"
-          on-click="onActionLinkClick_">
+      <a href="$i18n{settingsPrintingPage}" target="_none"
+          class="link" hidden$="[[!hasManageLink]]">
         $i18n{manage}
       </a>
       <div class="throbber-container" hidden$="[[!loadingDestinations]]">

chrome/browser/resources/print_preview/new/destination_list.js

@@ -18,7 +18,7 @@ Polymer({
     searchQuery: Object,
 
     /** @type {boolean} */
-    hasActionLink: {
+    hasManageLink: {
       type: Boolean,
       value: false,
     },
@@ -112,11 +112,6 @@ Polymer({
     this.showDestinationsTotal_ = count > 4;
   },
 
-  /** @private */
-  onActionLinkClick_: function() {
-    print_preview.NativeLayer.getInstance().managePrinters();
-  },
-
   /**
    * @param {!KeyboardEvent} e Event containing the destination and key.
    * @private

chrome/browser/ui/webui/print_preview/print_preview_handler.cc

@@ -975,6 +975,7 @@ void PrintPreviewHandler::HandleGetAccessToken(const base::ListValue* args) {
   token_service_->RequestToken(type, callback_id);
 }
 
+// TODO (rbpotter): Remove this when the old Print Preview page is deleted.
 void PrintPreviewHandler::HandleManagePrinters(const base::ListValue* args) {
   GURL local_printers_manage_url(
       chrome::GetSettingsUrl(chrome::kPrintingSettingsSubPage));

chrome/browser/ui/webui/print_preview/print_preview_handler.h

@@ -229,6 +229,7 @@ class PrintPreviewHandler
 
   // Brings up Chrome printing setting page to allow the user to configure local
   // printers or Google Cloud printers. |args| is unused.
+  // TODO (rbpotter): Remove this when the old Print Preview page is deleted.
   void HandleManagePrinters(const base::ListValue* args);
 
   // Gathers UMA stats when the print preview dialog is about to close.

chrome/browser/ui/webui/print_preview/print_preview_ui.cc

@@ -27,6 +27,7 @@
 #include "chrome/browser/printing/background_printing_manager.h"
 #include "chrome/browser/printing/print_preview_data_service.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/webui/metrics_handler.h"
 #include "chrome/browser/ui/webui/print_preview/print_preview_handler.h"
 #include "chrome/browser/ui/webui/theme_source.h"
@@ -251,6 +252,9 @@ void AddPrintPreviewStrings(content::WebUIDataSource* source) {
   source->AddString(
       "noDestsPromoLearnMoreUrl",
       chrome::kCloudPrintNoDestinationsLearnMoreURL);
+  source->AddString(
+      "settingsPrintingPage",
+      chrome::GetSettingsUrl(chrome::kPrintingSettingsSubPage).spec());
   source->AddString("gcpCertificateErrorLearnMoreURL",
                     chrome::kCloudPrintCertificateErrorLearnMoreURL);
   source->AddLocalizedString("pageRangeLimitInstruction",