Commit e41849ef authored by Tibor Goldschwendt's avatar Tibor Goldschwendt Committed by Chromium LUCI CQ

[ntp] Extend several histograms

We are still using them. Specifically, this CL extends the following
histograms:

* NewTabPage.BackgroundService.Collections.RequestLatency*
* NewTabPage.BackgroundService.Images.RequestLatency*
* NewTabPage.CustomizedShortcuts
* NewTabPage.CustomizeLocalImageBackgroundAction
* NewTabPage.CustomizeShortcutAction
* NewTabPage.LogoDownloadOutcome
* NewTabPage.LogoDownloadTime
* NewTabPage.LogoImageDownloaded
* NewTabPage.LogoShownTime2
* NewTabPage.Modules.ShownTime
* NewTabPage.Modules.Usage*
* NewTabPage.Promos.RequestLatency2*
* NewTabPage.RecipeTasks.RecipeClick
* NewTabPage.RecipeTasks.RelatedSearchClick
* NewTabPage.ShoppingTasks.ProductClick
* NewTabPage.ShoppingTasks.RelatedSearchClick
* NewTabPage.TileTitle*
* NewTabPage.URLState

Fixed: 1151982, 1156215, 1151981
Change-Id: Id31e792fe3d4b205ea8d1fd1ea5f17d9c5f4157b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611634
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840673}
parent 05c78ac7
...@@ -55,7 +55,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -55,7 +55,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.BackgroundService.Collections.RequestLatency" <histogram name="NewTabPage.BackgroundService.Collections.RequestLatency"
units="ms" expires_after="2021-01-01"> units="ms" expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.BackgroundService.Images.RequestLatency" units="ms" <histogram name="NewTabPage.BackgroundService.Images.RequestLatency" units="ms"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -607,7 +607,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -607,7 +607,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.CustomizedShortcuts" <histogram name="NewTabPage.CustomizedShortcuts"
enum="NTPCustomizedShortcutSettings" expires_after="2021-01-01"> enum="NTPCustomizedShortcutSettings" expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -619,7 +619,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -619,7 +619,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.CustomizeLocalImageBackgroundAction" <histogram name="NewTabPage.CustomizeLocalImageBackgroundAction"
enum="NTPCustomizeLocalImageBackgroundAction" expires_after="2021-01-01"> enum="NTPCustomizeLocalImageBackgroundAction" expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -631,7 +631,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -631,7 +631,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.CustomizeShortcutAction" <histogram name="NewTabPage.CustomizeShortcutAction"
enum="NTPCustomizeShortcutAction" expires_after="2021-01-01"> enum="NTPCustomizeShortcutAction" expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -680,7 +680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -680,7 +680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.LogoDownloadOutcome" <histogram name="NewTabPage.LogoDownloadOutcome"
enum="NewTabPageLogoDownloadOutcome" expires_after="2021-01-01"> enum="NewTabPageLogoDownloadOutcome" expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -691,7 +691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -691,7 +691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.LogoDownloadTime" units="ms" <histogram name="NewTabPage.LogoDownloadTime" units="ms"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -704,7 +704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -704,7 +704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.LogoImageDownloaded" enum="BooleanFromHTTPCache" <histogram name="NewTabPage.LogoImageDownloaded" enum="BooleanFromHTTPCache"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -727,7 +727,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -727,7 +727,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.LogoShownTime2" units="ms" <histogram name="NewTabPage.LogoShownTime2" units="ms"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -810,7 +810,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -810,7 +810,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.Modules.ShownTime" units="ms" <histogram name="NewTabPage.Modules.ShownTime" units="ms"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -821,7 +821,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -821,7 +821,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.Modules.Usage" units="count" <histogram name="NewTabPage.Modules.Usage" units="count"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1014,7 +1014,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1014,7 +1014,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.Promos.RequestLatency2" units="ms" <histogram name="NewTabPage.Promos.RequestLatency2" units="ms"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1052,7 +1052,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1052,7 +1052,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.RecipeTasks.RecipeClick" units="index" <histogram name="NewTabPage.RecipeTasks.RecipeClick" units="index"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1076,7 +1076,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1076,7 +1076,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.RecipeTasks.RelatedSearchClick" units="index" <histogram name="NewTabPage.RecipeTasks.RelatedSearchClick" units="index"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1233,7 +1233,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1233,7 +1233,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.ShoppingTasks.ProductClick" units="index" <histogram name="NewTabPage.ShoppingTasks.ProductClick" units="index"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1257,7 +1257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1257,7 +1257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.ShoppingTasks.RelatedSearchClick" units="index" <histogram name="NewTabPage.ShoppingTasks.RelatedSearchClick" units="index"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1488,7 +1488,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1488,7 +1488,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.TileTitle" enum="NTPTileTitleSource" <histogram name="NewTabPage.TileTitle" enum="NTPTileTitleSource"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
...@@ -1556,7 +1556,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1556,7 +1556,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="NewTabPage.URLState" enum="NewTabURLState" <histogram name="NewTabPage.URLState" enum="NewTabURLState"
expires_after="2021-01-01"> expires_after="2022-01-01">
<owner>tiborg@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-desktop-ntp@google.com</owner> <owner>chrome-desktop-ntp@google.com</owner>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment