Commit e41f9466 authored by Matt Jones's avatar Matt Jones Committed by Commit Bot

Remove unneeded controls update in Contextual Search

This patch also removes some plumbing that is no longer used as a
result of removing this update.

Change-Id: I624c0217054ee1954053d715b297a968dddcf43f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476898Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817703}
parent ed5f1fb4
...@@ -88,9 +88,4 @@ public class OverlayContentDelegate { ...@@ -88,9 +88,4 @@ public class OverlayContentDelegate {
* Called once the WebContents has been created and set up completely. * Called once the WebContents has been created and set up completely.
*/ */
public void onContentViewCreated() {} public void onContentViewCreated() {}
/**
* Called once the WebContents has been destroyed.
*/
public void onContentViewDestroyed() {}
} }
...@@ -416,9 +416,6 @@ public class OverlayPanelContent { ...@@ -416,9 +416,6 @@ public class OverlayPanelContent {
mShouldReuseWebContents = false; mShouldReuseWebContents = false;
setVisibility(false); setVisibility(false);
// After everything has been disposed, notify the observer.
mContentDelegate.onContentViewDestroyed();
} }
} }
......
...@@ -43,7 +43,6 @@ import org.chromium.chrome.browser.preferences.Pref; ...@@ -43,7 +43,6 @@ import org.chromium.chrome.browser.preferences.Pref;
import org.chromium.chrome.browser.profiles.Profile; import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.tab.SadTab; import org.chromium.chrome.browser.tab.SadTab;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabBrowserControlsConstraintsHelper;
import org.chromium.chrome.browser.tab.TabCreationState; import org.chromium.chrome.browser.tab.TabCreationState;
import org.chromium.chrome.browser.tab.TabLaunchType; import org.chromium.chrome.browser.tab.TabLaunchType;
import org.chromium.chrome.browser.tab.TabSelectionType; import org.chromium.chrome.browser.tab.TabSelectionType;
...@@ -1068,11 +1067,6 @@ public class ContextualSearchManager ...@@ -1068,11 +1067,6 @@ public class ContextualSearchManager
getSearchPanelWebContents()); getSearchPanelWebContents());
} }
@Override
public void onContentViewDestroyed() {
updateTabConstraints();
}
@Override @Override
public void onContentViewSeen() { public void onContentViewSeen() {
assert mSearchPanel != null; assert mSearchPanel != null;
...@@ -1108,14 +1102,6 @@ public class ContextualSearchManager ...@@ -1108,14 +1102,6 @@ public class ContextualSearchManager
// Search Content View // Search Content View
// ============================================================================================ // ============================================================================================
/**
* Update the state of the browser controls (whether they can be shown or hidden) based on the
* current tab.
*/
private void updateTabConstraints() {
TabBrowserControlsConstraintsHelper.updateEnabledState(mTabSupplier.get());
}
/** Removes the last resolved search URL from the Chrome history. */ /** Removes the last resolved search URL from the Chrome history. */
private void removeLastSearchVisit() { private void removeLastSearchVisit() {
assert mSearchPanel != null; assert mSearchPanel != null;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment