Commit e4390a97 authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Commit Bot

[iOS] Disable failing bookmarks tests

The following tests are being disabled on iphone-device:

BookmarksTestCase/testMoveDoesSaveOnSave
BookmarksTestCase/testEmptyBackgroundAndSelectButton
BookmarksTestCase/testBookmarkContextBarInMultipleSelectionModes
BookmarksTestCase/testBookmarkContextBarInSingleSelectionModes
BookmarksTestCase/testKeyboardCommandsNotRegistered_EditBookmark
BookmarksEntriesTestCase/testContextMenuForMixedSelection

TBR= sczs@chromium.org

Bug: 1045966
Change-Id: Idd767cc19e7443825be6f08680813732426770ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020932
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarJavier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735446}
parent ed8331aa
...@@ -153,6 +153,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel; ...@@ -153,6 +153,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel;
// Tests that changes to the parent folder from the Single Bookmark Editor // Tests that changes to the parent folder from the Single Bookmark Editor
// are saved to the bookmark only when saving the results. // are saved to the bookmark only when saving the results.
- (void)testMoveDoesSaveOnSave { - (void)testMoveDoesSaveOnSave {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
[BookmarkEarlGrey setupStandardBookmarks]; [BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks]; [BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks]; [BookmarkEarlGreyUI openMobileBookmarks];
...@@ -212,6 +219,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel; ...@@ -212,6 +219,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel;
// Tests that keyboard commands are not registered when a bookmark is edited, as // Tests that keyboard commands are not registered when a bookmark is edited, as
// the edit screen is presented modally. // the edit screen is presented modally.
- (void)testKeyboardCommandsNotRegistered_EditBookmark { - (void)testKeyboardCommandsNotRegistered_EditBookmark {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
[BookmarkEarlGrey setupStandardBookmarks]; [BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks]; [BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks]; [BookmarkEarlGreyUI openMobileBookmarks];
...@@ -314,6 +328,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel; ...@@ -314,6 +328,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel;
} }
- (void)testBookmarkContextBarInSingleSelectionModes { - (void)testBookmarkContextBarInSingleSelectionModes {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
[BookmarkEarlGrey setupStandardBookmarks]; [BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks]; [BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks]; [BookmarkEarlGreyUI openMobileBookmarks];
...@@ -448,6 +469,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel; ...@@ -448,6 +469,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel;
} }
- (void)testBookmarkContextBarInMultipleSelectionModes { - (void)testBookmarkContextBarInMultipleSelectionModes {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
[BookmarkEarlGrey setupStandardBookmarks]; [BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks]; [BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks]; [BookmarkEarlGreyUI openMobileBookmarks];
...@@ -624,6 +652,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel; ...@@ -624,6 +652,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel;
testEmptyBackgroundAndSelectButton testEmptyBackgroundAndSelectButton
#endif #endif
- (void)MAYBE_testEmptyBackgroundAndSelectButton { - (void)MAYBE_testEmptyBackgroundAndSelectButton {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
[BookmarkEarlGrey setupStandardBookmarks]; [BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks]; [BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks]; [BookmarkEarlGreyUI openMobileBookmarks];
......
...@@ -677,6 +677,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel; ...@@ -677,6 +677,13 @@ using chrome_test_util::TappableBookmarkNodeWithLabel;
} }
- (void)testContextMenuForMixedSelection { - (void)testContextMenuForMixedSelection {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif
[BookmarkEarlGrey setupStandardBookmarks]; [BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks]; [BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks]; [BookmarkEarlGreyUI openMobileBookmarks];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment