Remove workaround for missing function in Vulkan Swiftshader

vkGetPhysicalDeviceXlibPresentationSupportKHR is now supported.

Bug: swiftshader:129
Change-Id: Id7eaee8fd695cd1cb5875b8c524e9152bea2a461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656062
Auto-Submit: Saman Sami <samans@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668526}

gpu/vulkan/vulkan_instance.cc

@@ -48,8 +48,7 @@ VulkanInstance::~VulkanInstance() {
 
 bool VulkanInstance::Initialize(
     const std::vector<const char*>& required_extensions,
-    const std::vector<const char*>& required_layers,
-    bool using_swiftshader) {
+    const std::vector<const char*>& required_layers) {
   DCHECK(!vk_instance_);
 
   VulkanFunctionPointers* vulkan_function_pointers =
@@ -241,9 +240,7 @@ bool VulkanInstance::Initialize(
         reinterpret_cast<PFN_vkGetPhysicalDeviceXlibPresentationSupportKHR>(
             vkGetInstanceProcAddr(
                 vk_instance_, "vkGetPhysicalDeviceXlibPresentationSupportKHR"));
-    // TODO(samans): Remove |using_swiftshader| once Swiftshader supports this
-    // method. https://crbug.com/swiftshader/129
-    if (!vkGetPhysicalDeviceXlibPresentationSupportKHR && !using_swiftshader)
+    if (!vkGetPhysicalDeviceXlibPresentationSupportKHR)
       return false;
 #endif
 

gpu/vulkan/vulkan_instance.h

@@ -26,12 +26,8 @@ class VULKAN_EXPORT VulkanInstance {
   // The extensions in |required_extensions| and the layers in |required_layers|
   // will be enabled in the created instance. See the "Extended Functionality"
   // section of vulkan specification for more information.
-  // TODO(samans): Remove |using_swiftshader| once Vulkan Swiftshader is more
-  // developed and the workarounds that were added can be deleted.
-  // https://crbug.com/963988
   bool Initialize(const std::vector<const char*>& required_extensions,
-                  const std::vector<const char*>& required_layers,
-                  bool using_swiftshader = false);
+                  const std::vector<const char*>& required_layers);
 
   // VkApplicationInfo.apiVersion value used to initialize the instance.
   uint32_t api_version() const { return api_version_; }

gpu/vulkan/x/vulkan_implementation_x11.cc

@@ -76,7 +76,7 @@ bool VulkanImplementationX11::InitializeVulkanInstance(bool using_surface) {
   if (!vulkan_function_pointers->vulkan_loader_library_)
     return false;
 
-  if (!vulkan_instance_.Initialize(required_extensions, {}, use_swiftshader()))
+  if (!vulkan_instance_.Initialize(required_extensions, {}))
     return false;
   return true;
 }