Commit e458d3ca authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove set_sources_assignment_filter from //components/dom_distiller

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I1d381903ba67fb0ab666976478f909212bf8ba5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409939Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806673}
parent a5949822
...@@ -2,6 +2,12 @@ ...@@ -2,6 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
static_library("core") { static_library("core") {
sources = [ sources = [
"article_distillation_update.cc", "article_distillation_update.cc",
...@@ -14,8 +20,6 @@ static_library("core") { ...@@ -14,8 +20,6 @@ static_library("core") {
"distilled_content_store.h", "distilled_content_store.h",
"distilled_page_prefs.cc", "distilled_page_prefs.cc",
"distilled_page_prefs.h", "distilled_page_prefs.h",
"distilled_page_prefs_android.cc",
"distilled_page_prefs_android.h",
"distiller.cc", "distiller.cc",
"distiller.h", "distiller.h",
"distiller_page.cc", "distiller_page.cc",
...@@ -45,7 +49,6 @@ static_library("core") { ...@@ -45,7 +49,6 @@ static_library("core") {
"url_constants.h", "url_constants.h",
"url_utils.cc", "url_utils.cc",
"url_utils.h", "url_utils.h",
"url_utils_android.cc",
"viewer.cc", "viewer.cc",
"viewer.h", "viewer.h",
] ]
...@@ -73,8 +76,11 @@ static_library("core") { ...@@ -73,8 +76,11 @@ static_library("core") {
if (is_android) { if (is_android) {
sources += [ sources += [
"distilled_page_prefs_android.cc",
"distilled_page_prefs_android.h",
"dom_distiller_service_android.cc", "dom_distiller_service_android.cc",
"dom_distiller_service_android.h", "dom_distiller_service_android.h",
"url_utils_android.cc",
] ]
deps += [ ":jni_headers" ] deps += [ ":jni_headers" ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment