Commit e45d23c1 authored by Mason Freed's avatar Mason Freed Committed by Chromium LUCI CQ

Remove unnecessary code for <dialog> 'open' presentation attribute

This code was added in [1] to work around a bug [2] in the layout test
system that doesn't seem to still reproduce. The "open" attribute is
not a presentation attribute, so it shouldn't be marked as one.

This should not change any behavior.

[1] https://source.chromium.org/chromium/chromium/src/+/f56b6ef2b68e305e106e0310fd884c620861fb8b
[2] https://bugs.webkit.org/show_bug.cgi?id=91058

Change-Id: If03bf98075db8b94e56f27370199a36e508106b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640923
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Reviewed-by: default avatarYu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845895}
parent a02e2dc2
...@@ -195,17 +195,6 @@ void HTMLDialogElement::RemovedFrom(ContainerNode& insertion_point) { ...@@ -195,17 +195,6 @@ void HTMLDialogElement::RemovedFrom(ContainerNode& insertion_point) {
InertSubtreesChanged(GetDocument()); InertSubtreesChanged(GetDocument());
} }
bool HTMLDialogElement::IsPresentationAttribute(
const QualifiedName& name) const {
// FIXME: Workaround for <https://bugs.webkit.org/show_bug.cgi?id=91058>:
// modifying an attribute for which there is an attribute selector in html.css
// sometimes does not trigger a style recalc.
if (name == html_names::kOpenAttr)
return true;
return HTMLElement::IsPresentationAttribute(name);
}
void HTMLDialogElement::DefaultEventHandler(Event& event) { void HTMLDialogElement::DefaultEventHandler(Event& event) {
if (event.type() == event_type_names::kCancel) { if (event.type() == event_type_names::kCancel) {
close(); close();
......
...@@ -33,7 +33,6 @@ namespace blink { ...@@ -33,7 +33,6 @@ namespace blink {
class Document; class Document;
class ExceptionState; class ExceptionState;
class QualifiedName;
class HTMLDialogElement final : public HTMLElement { class HTMLDialogElement final : public HTMLElement {
DEFINE_WRAPPERTYPEINFO(); DEFINE_WRAPPERTYPEINFO();
...@@ -54,7 +53,6 @@ class HTMLDialogElement final : public HTMLElement { ...@@ -54,7 +53,6 @@ class HTMLDialogElement final : public HTMLElement {
} }
private: private:
bool IsPresentationAttribute(const QualifiedName&) const override;
void DefaultEventHandler(Event&) override; void DefaultEventHandler(Event&) override;
void SetIsModal(bool is_modal); void SetIsModal(bool is_modal);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment