Commit e466fa3b authored by Roman Sorokin [CET]'s avatar Roman Sorokin [CET]

[Sheriff] Revert "Re-enable flaky TranslateIframe test and add extra debug information"

This reverts commit 46a70005.

Reason for revert: fails on multiple builders (https://crbug.com/1109637)

Original change's description:
> Re-enable flaky TranslateIframe test and add extra debug information
>
> This test has been disabled in https://crrev.com/c/2303433 due to it
> being flaky. However its stack trace matches the one observed recently
> in production code (crbug.com/1107103) so we're re-enabling it now and
> adding some extra debugging information in order to help us fix the
> issue, as it hasn't been possible to reproduce it locally so far.
>
> Bug: 1107103
> Change-Id: Ifeee8483c83e72b52a232b71ef2437ecab6bf305
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316101
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
> Auto-Submit: Mario Sanchez Prada <mario@igalia.com>
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#791714}

TBR=dmazzoni@chromium.org,hajimehoshi@chromium.org,mario@igalia.com

Change-Id: I2f2cde72fa5c6e39dacaf819d96ac30bf22ef34f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1107103
Bug: 1109637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317951
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791746}
parent 1088890e
......@@ -2019,7 +2019,7 @@ class TranslateManagerWithMainFrameLanguageDetectionBrowserTest
// TODO(https://crbug.com/1106620): Disabled due to flake and crashes.
IN_PROC_BROWSER_TEST_F(
TranslateManagerWithMainFrameLanguageDetectionBrowserTest,
TranslateIframe) {
DISABLED_TranslateIframe) {
base::HistogramTester histograms;
SetTranslateScript(kTestValidScript);
......
......@@ -1353,10 +1353,8 @@ bool AXTree::ComputePendingChangesToNode(const AXNodeData& new_data,
if (!update_state->IncrementPendingCreateNodeCount(child_id,
new_data.id)) {
error_ = base::StringPrintf(
"Node %d from |new_child_id_set| is already pending for "
"creation, cannot be a new child (of parent %d)\n"
"Parent Node info:\n%s",
child_id, new_data.id, new_data.ToString().c_str());
"Node %d is already pending for creation, cannot be a new child",
child_id);
return false;
}
}
......@@ -1408,10 +1406,8 @@ bool AXTree::ComputePendingChangesToNode(const AXNodeData& new_data,
if (!update_state->IncrementPendingCreateNodeCount(child_id,
new_data.id)) {
error_ = base::StringPrintf(
"Node %d from |create_or_destroy_ids| is already pending for "
"creation, cannot be a new child (of parent %d)\n"
"Parent Node info:\n%s",
child_id, new_data.id, new_data.ToString().c_str());
"Node %d is already pending for creation, cannot be a new child",
child_id);
return false;
}
} else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment