Commit e4997e81 authored by Matt Simmons's avatar Matt Simmons Committed by Commit Bot

Fix text theming bug in Clank Start Phase 2.

This CL fixes 2 bugs with Clank Start Phase 2.

1. When focusing URL bar, the current tab's URL was displaying.

2. Primary color was returning default color during tab switcher exit
transition. Fixed by observing if a tab switcher exit is in progress.

R=yusufo@chromium.org

Bug: 968210
Change-Id: Id2a934be168e38aa5ffd50f6bddbe393e8500c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635415Reviewed-by: default avatarYusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664823}
parent 26607e81
...@@ -1866,19 +1866,12 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O ...@@ -1866,19 +1866,12 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O
if (inTabSwitcherMode) { if (inTabSwitcherMode) {
mUrlBar.setText(""); mUrlBar.setText("");
mLocationBar.updateStatusIcon(); } else if (getToolbarDataProvider() != null
// Early return here allows the location bar to remain visible and functional while && getToolbarDataProvider().getUrlBarData() != null) {
// the tab switcher (overview) is being displayed.
return true;
}
if (getToolbarDataProvider() != null && getToolbarDataProvider().getUrlBarData() != null) {
// Set the text back to the correct display text in case we've previously cleared
// it.
mUrlBar.setText(getToolbarDataProvider().getUrlBarData().displayText); mUrlBar.setText(getToolbarDataProvider().getUrlBarData().displayText);
} }
return false; return true;
} }
@Override @Override
...@@ -2096,9 +2089,9 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O ...@@ -2096,9 +2089,9 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O
if (mToggleTabStackButton != null) mToggleTabStackButton.setClickable(!hasFocus); if (mToggleTabStackButton != null) mToggleTabStackButton.setClickable(!hasFocus);
if (getToolbarDataProvider().isInOverviewAndShowingOmnibox() && !hasFocus) { if (getToolbarDataProvider().isInOverviewAndShowingOmnibox()) {
mUrlBar.setText(""); mUrlBar.setText("");
return; if (!hasFocus) return;
} }
triggerUrlFocusAnimation(hasFocus); triggerUrlFocusAnimation(hasFocus);
...@@ -2149,9 +2142,12 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O ...@@ -2149,9 +2142,12 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O
mLocationBar.finishUrlFocusChange(hasFocus); mLocationBar.finishUrlFocusChange(hasFocus);
mUrlFocusChangeInProgress = false; mUrlFocusChangeInProgress = false;
if (getToolbarDataProvider().isInOverviewAndShowingOmnibox()) { if (getToolbarDataProvider().shouldShowLocationBarInOverviewMode()) {
mLocationBar.updateVisualsForState(); mLocationBar.updateStatusIcon();
mUrlBar.setText("");
if (getToolbarDataProvider().isInOverviewAndShowingOmnibox()) {
mUrlBar.setText("");
}
} }
} }
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment