Commit e4c2bbbb authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Mark a state as unreachable in SearchTabHelper::FocusOmnibox().

Change-Id: If3b12f9ef36d20c43283fba936bdf4f9be7c1889
Reviewed-on: https://chromium-review.googlesource.com/1214742Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589973}
parent cf2eb4a3
...@@ -258,8 +258,7 @@ void SearchTabHelper::FocusOmnibox(OmniboxFocusState state) { ...@@ -258,8 +258,7 @@ void SearchTabHelper::FocusOmnibox(OmniboxFocusState state) {
// doing nothing instead of crashing the browser process (intentional no-op). // doing nothing instead of crashing the browser process (intentional no-op).
switch (state) { switch (state) {
case OMNIBOX_FOCUS_VISIBLE: case OMNIBOX_FOCUS_VISIBLE:
omnibox_view->SetFocus(); NOTREACHED();
omnibox_view->model()->SetCaretVisibility(true);
break; break;
case OMNIBOX_FOCUS_INVISIBLE: case OMNIBOX_FOCUS_INVISIBLE:
omnibox_view->SetFocus(); omnibox_view->SetFocus();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment