Commit e4cc0e21 authored by Miyoung Shin's avatar Miyoung Shin Committed by Commit Bot

Add a warning of using std::unordered_set and std::unordered_map to audit_non_blink_usage.py

This CL adds an audit check for the banned std containers to
ensure the new usage of std::unordered_set and std::unordered_map
doesn't come in, and updates the warning message to clarify to
allow the use case at the boundary layer between Blink and
Chromium.

Bug: 952716
Change-Id: Idca01e5d96a515a9dcff7e8f347248944a540a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691909
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676367}
parent d903b425
...@@ -404,8 +404,10 @@ _CONFIG = [ ...@@ -404,8 +404,10 @@ _CONFIG = [
'disallowed': [ 'disallowed': [
('base::Bind(|Once|Repeating)', ('base::Bind(|Once|Repeating)',
'Use WTF::Bind or WTF::BindRepeating.'), 'Use WTF::Bind or WTF::BindRepeating.'),
('std::(deque|map|set|vector)', ('std::(deque|map|set|vector|unordered_set|unordered_map)',
'Use WTF containers like WTF::Deque, WTF::HashMap, WTF::HashSet or WTF::Vector instead of the banned std containers.'), 'Use WTF containers like WTF::Deque, WTF::HashMap, WTF::HashSet or WTF::Vector instead of the banned std containers. '
'However, it is fine to use std containers at the boundary layer between Blink and Chromium. '
'If you are in this case, you can use --bypass-hooks option to avoid the presubmit check when uploading your CL.'),
], ],
}, },
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment