Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make asssertions that the URL was changing and that the RenderWidget was being created. Validating the page title is an easy way to make sure the intended page is actually the one being sent. BUG=628324 Review-Url: https://codereview.chromium.org/2224613002 Cr-Commit-Position: refs/heads/master@{#410398}

Validate the page title in engine browser test.
Prior to this change, the engine browser test would only make asssertions that the URL was changing and that the RenderWidget was being created. Validating the page title is an easy way to make sure the intended page is actually the one being sent. BUG=628324 Review-Url: https://codereview.chromium.org/2224613002 Cr-Commit-Position: refs/heads/master@{#410398}
e4e2ca8a · bgoldman · Commit bot · 38fdd175 · e4e2ca8a · e4e2ca8a
Commit e4e2ca8a authored Aug 08, 2016 by bgoldman Committed by Commit bot Aug 08, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

blimp/engine/browser_tests/engine_browsertest.cc blimp/engine/browser_tests/engine_browsertest.cc +6 -1

blimp/test/data/hello.html blimp/test/data/hello.html +1 -0

No files found.
--- a/blimp/engine/browser_tests/engine_browsertest.cc
+++ b/blimp/engine/browser_tests/engine_browsertest.cc
@@ -59,11 +59,16 @@ class EngineBrowserTest : public BlimpBrowserTest {
 };

 IN_PROC_BROWSER_TEST_F(EngineBrowserTest, LoadUrl) {
+  testing::InSequence s;
+
  EXPECT_TRUE(embedded_test_server()->Start());
  GURL url = embedded_test_server()->GetURL("/hello.html");

  EXPECT_CALL(client_rw_feature_delegate_, OnRenderWidgetCreated(1));
-  EXPECT_CALL(client_nav_feature_delegate_, OnUrlChanged(kDummyTabId, url))
+  EXPECT_CALL(client_nav_feature_delegate_,
+              OnTitleChanged(kDummyTabId, url.GetContent()));
+  EXPECT_CALL(client_nav_feature_delegate_,
+              OnTitleChanged(kDummyTabId, "hello"))
      .WillOnce(InvokeWithoutArgs(this, &EngineBrowserTest::QuitRunLoop));

  // Skip assigner. Engine info is already available.

--- a/blimp/test/data/hello.html
+++ b/blimp/test/data/hello.html
 <!doctype html>
+<title>hello</title>
 <h1>Hello world!</h1>