Commit e50427f3 authored by DongJun Kim's avatar DongJun Kim Committed by Commit Bot

Remove DeprecatedEqualIgnoringCase in renderer/core/html

This CL migrates the remaining comparisons involving an ASCII literal
from DeprecatedEqualIgnoringCase to EqualIgnoringASCIICase.

In case of SanitizeValue() in "color_input_type.cc",
Only ASCII (#0-9) and (A-F) characters are involved (not S or K)
in the right hand side, this is effectively not a behavior change.

Also this changes are potentially author-facing, but We’ve optimistically
made them without any additional tests based on Rick Byers’ reasoning
on blink-dev [1].

[1]https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ

Bug: 627682
Signed-off-by: default avatarDongJun Kim <djmix.kim@samsung.com>
Change-Id: I55afbc42c98ce105a7f94aa572ebb389115f619b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108240Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarFrédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#754766}
parent a9399b96
......@@ -188,7 +188,7 @@ bool ColorInputType::TypeMismatchFor(const String& value) const {
}
void ColorInputType::WarnIfValueIsInvalid(const String& value) const {
if (!DeprecatedEqualIgnoringCase(value, GetElement().SanitizeValue(value)))
if (!EqualIgnoringASCIICase(value, GetElement().SanitizeValue(value)))
AddWarningToConsole(
"The specified value %s does not conform to the required format. The "
"format is \"#rrggbb\" where rr, gg, bb are two-digit hexadecimal "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment