2009-04-27 Simon Fraser <simon.fraser@apple.com>

        Reviewed by Adele Peterson

        <rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well

        Fix a 'size changed' notification thrash that caused standalone video elements
        to continually resize after full page zooming, by using the movie's natual size (which is independent
        of zooming), rather than its current size (which is not).

        Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
        disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
        QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
        <rdar://problem/6822344>.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::naturalSize):

git-svn-id: svn://svn.chromium.org/blink/trunk@42914 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 23a8bb3c
2009-04-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adele Peterson
<rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
Skip the test added for https://bugs.webkit.org/show_bug.cgi?id=25029, which will
get re-enabled once <rdar://problem/6822344> is fixed.
* platform/mac/Skipped:
2009-04-27 Chris Fleizach <cfleizach@apple.com> 2009-04-27 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin. Reviewed by Beth Dakin.
...@@ -65,4 +65,7 @@ svg/hixie/perf/001.xml ...@@ -65,4 +65,7 @@ svg/hixie/perf/001.xml
svg/hixie/perf/002.xml svg/hixie/perf/002.xml
# <rdar://problem/6710625> Test media/video-error-abort.html doesn't work # <rdar://problem/6710625> Test media/video-error-abort.html doesn't work
media/video-error-abort.html media/video-error-abort.html
\ No newline at end of file
#<rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception
media/video-size-intrinsic-scale.html
2009-04-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adele Peterson
<rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
Fix a 'size changed' notification thrash that caused standalone video elements
to continually resize after full page zooming, by using the movie's natual size (which is independent
of zooming), rather than its current size (which is not).
Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
<rdar://problem/6822344>.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::naturalSize):
2009-04-27 Simon Fraser <simon.fraser@apple.com> 2009-04-27 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler Reviewed by Darin Adler
...@@ -563,14 +563,7 @@ IntSize MediaPlayerPrivate::naturalSize() const ...@@ -563,14 +563,7 @@ IntSize MediaPlayerPrivate::naturalSize() const
if (!metaDataAvailable()) if (!metaDataAvailable())
return IntSize(); return IntSize();
// In spite of the name of this method, return QTMovieCurrentSizeAttribute rather than return IntSize([[m_qtMovie.get() attributeForKey:QTMovieNaturalSizeAttribute] sizeValue]);
// QTMovieNaturalSizeAttribute because we need to return:
//
// ... the dimensions of the resource in CSS pixels after taking into account the resource's
// dimensions, aspect ratio, clean aperture, resolution, and so forth, as defined for the
// format used by the resource
return IntSize([[m_qtMovie.get() attributeForKey:QTMovieCurrentSizeAttribute] sizeValue]);
} }
bool MediaPlayerPrivate::hasVideo() const bool MediaPlayerPrivate::hasVideo() const
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment