Commit e544af06 authored by Yue Zhang's avatar Yue Zhang Committed by Commit Bot

Auto-select all texts when tab group title is focused

Bug: 1116644
Change-Id: I2607ded4d277328067b79f5127664c7a457ba09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383092Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803662}
parent 9c15a3ac
...@@ -38,7 +38,8 @@ ...@@ -38,7 +38,8 @@
android:inputType="text|textNoSuggestions" android:inputType="text|textNoSuggestions"
android:imeOptions="actionDone" android:imeOptions="actionDone"
android:theme="@style/TabGridDialogTitleTheme" android:theme="@style/TabGridDialogTitleTheme"
android:gravity="center"/> android:gravity="center"
android:selectAllOnFocus="true"/>
<org.chromium.ui.widget.ChromeImageView <org.chromium.ui.widget.ChromeImageView
android:id="@+id/toolbar_right_button" android:id="@+id/toolbar_right_button"
style="@style/BottomToolbarButton" style="@style/BottomToolbarButton"
......
...@@ -600,7 +600,7 @@ public class TabGridDialogTest { ...@@ -600,7 +600,7 @@ public class TabGridDialogTest {
openDialogFromTabSwitcherAndVerify(cta, 2, openDialogFromTabSwitcherAndVerify(cta, 2,
cta.getResources().getQuantityString( cta.getResources().getQuantityString(
R.plurals.bottom_tab_grid_title_placeholder, 2, 2)); R.plurals.bottom_tab_grid_title_placeholder, 2, 2));
editDialogTitle(cta, CUSTOMIZED_TITLE1); editDialogTitle(CUSTOMIZED_TITLE1);
// Verify the title is updated in both tab switcher and dialog. // Verify the title is updated in both tab switcher and dialog.
clickScrimToExitDialog(cta); clickScrimToExitDialog(cta);
...@@ -611,7 +611,7 @@ public class TabGridDialogTest { ...@@ -611,7 +611,7 @@ public class TabGridDialogTest {
// Modify title in dialog from tab strip. // Modify title in dialog from tab strip.
clickFirstTabInDialog(cta); clickFirstTabInDialog(cta);
openDialogFromStripAndVerify(cta, 2, CUSTOMIZED_TITLE1); openDialogFromStripAndVerify(cta, 2, CUSTOMIZED_TITLE1);
editDialogTitle(cta, CUSTOMIZED_TITLE2); editDialogTitle(CUSTOMIZED_TITLE2);
clickScrimToExitDialog(cta); clickScrimToExitDialog(cta);
waitForDialogHidingAnimation(cta); waitForDialogHidingAnimation(cta);
...@@ -776,7 +776,7 @@ public class TabGridDialogTest { ...@@ -776,7 +776,7 @@ public class TabGridDialogTest {
// Content description should update with group title. // Content description should update with group title.
openDialogFromTabSwitcherAndVerify(cta, 3, null); openDialogFromTabSwitcherAndVerify(cta, 3, null);
editDialogTitle(cta, CUSTOMIZED_TITLE1); editDialogTitle(CUSTOMIZED_TITLE1);
clickScrimToExitDialog(cta); clickScrimToExitDialog(cta);
waitForDialogHidingAnimationInTabSwitcher(cta); waitForDialogHidingAnimationInTabSwitcher(cta);
verifyFirstCardTitle(CUSTOMIZED_TITLE1); verifyFirstCardTitle(CUSTOMIZED_TITLE1);
...@@ -1096,9 +1096,16 @@ public class TabGridDialogTest { ...@@ -1096,9 +1096,16 @@ public class TabGridDialogTest {
}); });
} }
private void editDialogTitle(ChromeTabbedActivity cta, String title) { private void editDialogTitle(String title) {
onView(allOf(withParent(withId(R.id.main_content)), withId(R.id.title))) onView(allOf(withParent(withId(R.id.main_content)), withId(R.id.title)))
.perform(click(), replaceText(title)); .perform(click())
.check((v, e) -> {
// Verify all texts in the field are selected.
EditText titleView = (EditText) v;
assertEquals(titleView.getText().length(),
titleView.getSelectionEnd() - titleView.getSelectionStart());
})
.perform(replaceText(title));
} }
private void verifyFirstCardTitle(String title) { private void verifyFirstCardTitle(String title) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment