Commit e5531783 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Replace uses of deprecated v8::Value::Equals

Use v8::Value::SameValue instead which does not require a Context and
works just as well (if not faster) when both arguments are v8::Strings.

Change-Id: I41f4e2b78f94671b4408c45b97c0e7b22ba554fb
Reviewed-on: https://chromium-review.googlesource.com/1150524Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580304}
parent c450408f
......@@ -53,9 +53,11 @@ class BenchmarkingWrapper : public v8::Extension {
v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
v8::Isolate* isolate,
v8::Local<v8::String> name) override {
if (name->Equals(v8::String::NewFromUtf8(isolate, "IsSingleProcess"))) {
if (name->StringEquals(
v8::String::NewFromUtf8(isolate, "IsSingleProcess"))) {
return v8::FunctionTemplate::New(isolate, IsSingleProcess);
} else if (name->Equals(v8::String::NewFromUtf8(isolate, "HiResTime"))) {
} else if (name->StringEquals(
v8::String::NewFromUtf8(isolate, "HiResTime"))) {
return v8::FunctionTemplate::New(isolate, HiResTime);
}
......
......@@ -64,9 +64,9 @@ class LoadTimesExtensionWrapper : public v8::Extension {
v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
v8::Isolate* isolate,
v8::Local<v8::String> name) override {
if (name->Equals(v8::String::NewFromUtf8(isolate, "GetLoadTimes"))) {
if (name->StringEquals(v8::String::NewFromUtf8(isolate, "GetLoadTimes"))) {
return v8::FunctionTemplate::New(isolate, GetLoadTimes);
} else if (name->Equals(v8::String::NewFromUtf8(isolate, "GetCSI"))) {
} else if (name->StringEquals(v8::String::NewFromUtf8(isolate, "GetCSI"))) {
return v8::FunctionTemplate::New(isolate, GetCSI);
}
return v8::Local<v8::FunctionTemplate>();
......
......@@ -48,15 +48,15 @@ class NetBenchmarkingWrapper : public v8::Extension {
v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
v8::Isolate* isolate,
v8::Local<v8::String> name) override {
if (name->Equals(v8::String::NewFromUtf8(isolate, "ClearCache"))) {
if (name->StringEquals(v8::String::NewFromUtf8(isolate, "ClearCache"))) {
return v8::FunctionTemplate::New(isolate, ClearCache);
} else if (name->Equals(v8::String::NewFromUtf8(
} else if (name->StringEquals(v8::String::NewFromUtf8(
isolate, "ClearHostResolverCache"))) {
return v8::FunctionTemplate::New(isolate, ClearHostResolverCache);
} else if (name->Equals(
} else if (name->StringEquals(
v8::String::NewFromUtf8(isolate, "ClearPredictorCache"))) {
return v8::FunctionTemplate::New(isolate, ClearPredictorCache);
} else if (name->Equals(
} else if (name->StringEquals(
v8::String::NewFromUtf8(isolate, "CloseConnections"))) {
return v8::FunctionTemplate::New(isolate, CloseConnections);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment