Commit e56eb0fa authored by Toni Barzic's avatar Toni Barzic Committed by Commit Bot

Disable contextual nudges for HotseatShelfAppBrowserTest.EnableChromeVox

If the test takes long enough, the contextual nudge will pop up, and add
a ChromeVox announcement unexpected by the tests - for now, disable
nudges for the test.

BUG=1058682

Change-Id: Idfa7d452958c7052435f43d7c8a997fb527d5402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088688Reviewed-by: default avatarNancy Wang <nancylingwang@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747112}
parent 869df94a
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include "ash/public/cpp/app_list/app_list_features.h" #include "ash/public/cpp/app_list/app_list_features.h"
#include "ash/public/cpp/app_list/app_list_switches.h" #include "ash/public/cpp/app_list/app_list_switches.h"
#include "ash/public/cpp/app_menu_constants.h" #include "ash/public/cpp/app_menu_constants.h"
#include "ash/public/cpp/ash_features.h"
#include "ash/public/cpp/shelf_item_delegate.h" #include "ash/public/cpp/shelf_item_delegate.h"
#include "ash/public/cpp/shelf_model.h" #include "ash/public/cpp/shelf_model.h"
#include "ash/public/cpp/shelf_test_api.h" #include "ash/public/cpp/shelf_test_api.h"
...@@ -2269,8 +2270,10 @@ class HotseatShelfAppBrowserTest : public ShelfAppBrowserTest { ...@@ -2269,8 +2270,10 @@ class HotseatShelfAppBrowserTest : public ShelfAppBrowserTest {
// ShelfAppBrowserTest: // ShelfAppBrowserTest:
void SetUp() override { void SetUp() override {
scoped_feature_list_.InitAndEnableFeature( // Disable contextual nudges to prevent in-app to home nudge from being
chromeos::features::kShelfHotseat); // announced in the ChromeVox test.
scoped_feature_list_.InitWithFeatures({chromeos::features::kShelfHotseat},
{ash::features::kContextualNudges});
ShelfAppBrowserTest::SetUp(); ShelfAppBrowserTest::SetUp();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment