Commit e5806b10 authored by Connie Wan's avatar Connie Wan Committed by Commit Bot

Remove implicit group creation on ctrl+click

We've gotten enough feedback on this that PM and UX have suggested that we remove this behavior.

This change removes the groups that are magically created when the user opens a new tab via a link. Tabs opened from an already-grouped tab will still be opened within that group.


Bug: 997344
Change-Id: Iad1ede15edc06356db9728bbcf5e4f59a4eae207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898620Reviewed-by: default avatarCharlene Yan <cyan@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712634}
parent 9abb23d2
......@@ -112,10 +112,6 @@ void ConfigureTabGroupForNavigation(NavigateParams* nav_params) {
if (nav_params->disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB ||
nav_params->disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB) {
nav_params->group = model->GetTabGroupForTab(source_index);
// TODO(crbug.com / 997344): Re-evaluate implicit link creation, and either
// remove this or add tests.
if (!nav_params->group)
nav_params->group = model->AddToNewGroup({source_index});
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment