Commit e5937374 authored by Matthias Körber's avatar Matthias Körber Committed by Commit Bot

[Autofill] Remove finch guard to import prefilled state/country values

Change-Id: I1b90d3ec7dc4a8d7856d661b6f0aa9ef0e454cc3
Bug: 1100231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505760
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: default avatarChristoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#822747}
parent 1501bcb1
...@@ -1135,14 +1135,12 @@ void FormStructure::RetrieveFromCache( ...@@ -1135,14 +1135,12 @@ void FormStructure::RetrieveFromCache(
field->value = cached_field->value; field->value = cached_field->value;
value_from_dynamic_change_form_ = true; value_from_dynamic_change_form_ = true;
} else if (field->value == cached_field->value && } else if (field->value == cached_field->value &&
(!base::FeatureList::IsEnabled( (field->server_type() != ADDRESS_HOME_COUNTRY &&
features:: field->server_type() != ADDRESS_HOME_STATE)) {
kAutofillImportPrefilledCountryAndStateValues) ||
(field->server_type() != ADDRESS_HOME_COUNTRY &&
field->server_type() != ADDRESS_HOME_STATE))) {
// TODO(crbug.com/1100231): Remove feature check once launched.
// From the perspective of learning user data, text fields containing // From the perspective of learning user data, text fields containing
// default values are equivalent to empty fields. // default values are equivalent to empty fields.
// Since a website can prefill country and state values basedw on
// GeoIp, the mechanism is deactivated for state and country fields.
field->value = base::string16(); field->value = base::string16();
} }
} }
......
...@@ -158,13 +158,6 @@ const base::Feature kAutofillExtractAllDatalists{ ...@@ -158,13 +158,6 @@ const base::Feature kAutofillExtractAllDatalists{
const base::Feature kAutofillFixFillableFieldTypes{ const base::Feature kAutofillFixFillableFieldTypes{
"AutofillFixFillableFieldTypes", base::FEATURE_DISABLED_BY_DEFAULT}; "AutofillFixFillableFieldTypes", base::FEATURE_DISABLED_BY_DEFAULT};
// If enabled, prefilled country and state values are not reset before
// an address profile import.
// TODO(crbug.com/1100231): Remove once fix is tested.
const base::Feature kAutofillImportPrefilledCountryAndStateValues{
"AutofillImportPrefilledCountryAndStateValues",
base::FEATURE_ENABLED_BY_DEFAULT};
// When enabled, Autofill keeps the initial field values in the |FormStructure| // When enabled, Autofill keeps the initial field values in the |FormStructure|
// cache for all field types. // cache for all field types.
const base::Feature kAutofillKeepInitialFormValuesInCache{ const base::Feature kAutofillKeepInitialFormValuesInCache{
......
...@@ -46,7 +46,6 @@ extern const base::Feature kAutofillEnforceMinRequiredFieldsForQuery; ...@@ -46,7 +46,6 @@ extern const base::Feature kAutofillEnforceMinRequiredFieldsForQuery;
extern const base::Feature kAutofillEnforceMinRequiredFieldsForUpload; extern const base::Feature kAutofillEnforceMinRequiredFieldsForUpload;
extern const base::Feature kAutofillExtractAllDatalists; extern const base::Feature kAutofillExtractAllDatalists;
extern const base::Feature kAutofillFixFillableFieldTypes; extern const base::Feature kAutofillFixFillableFieldTypes;
extern const base::Feature kAutofillImportPrefilledCountryAndStateValues;
extern const base::Feature kAutofillKeepInitialFormValuesInCache; extern const base::Feature kAutofillKeepInitialFormValuesInCache;
extern const base::Feature kAutofillRetrieveFromCacheWithRendererIds; extern const base::Feature kAutofillRetrieveFromCacheWithRendererIds;
extern const base::Feature extern const base::Feature
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment