Add WebappsClient::OnWebApkInstallInitiatedFromAppMenu

This allows Chrome to do logging for the IPH feature.

Bug: 1164069
Change-Id: I57bd7dc364d1b9d913b1ea316a4df8b1951c3f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616489Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841492}

chrome/browser/android/webapps/add_to_homescreen_mediator.cc

@@ -16,11 +16,9 @@
 #include "chrome/browser/banners/app_banner_manager_android.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
-#include "chrome/browser/feature_engagement/tracker_factory.h"
-#include "components/feature_engagement/public/event_constants.h"
-#include "components/feature_engagement/public/tracker.h"
 #include "components/url_formatter/elide_url.h"
 #include "components/webapps/installable/installable_metrics.h"
+#include "components/webapps/webapps_client.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/gfx/android/java_bitmap.h"
 
@@ -216,11 +214,8 @@ void AddToHomescreenMediator::OnDataAvailable(const webapps::ShortcutInfo& info,
                             entry, AppTypeToMenuEntry::kAppTypeFinalEntry);
 
   if (is_webapk) {
-    DVLOG(2) << "Sending event: IPH used for Installing PWA";
-    feature_engagement::Tracker* tracker =
-        feature_engagement::TrackerFactory::GetForBrowserContext(
-            data_fetcher_->web_contents()->GetBrowserContext());
-    tracker->NotifyEvent(feature_engagement::events::kPwaInstallMenuSelected);
+    webapps::WebappsClient::Get()->OnWebApkInstallInitiatedFromAppMenu(
+        data_fetcher_->web_contents());
   }
 }
 

chrome/browser/webapps/chrome_webapps_client.cc

@@ -13,6 +13,9 @@
 #include "chrome/browser/android/tab_android.h"
 #include "chrome/browser/android/tab_web_contents_delegate_android.h"
 #include "chrome/browser/android/webapk/webapk_install_service.h"
+#include "chrome/browser/feature_engagement/tracker_factory.h"
+#include "components/feature_engagement/public/event_constants.h"
+#include "components/feature_engagement/public/tracker.h"
 #endif
 
 namespace webapps {
@@ -84,6 +87,15 @@ bool ChromeWebappsClient::CanShowAppBanners(
                     tab->web_contents()->GetDelegate())
                     ->CanShowAppBanners();
 }
+
+void ChromeWebappsClient::OnWebApkInstallInitiatedFromAppMenu(
+    content::WebContents* web_contents) {
+  DVLOG(2) << "Sending event: IPH used for Installing PWA";
+  feature_engagement::Tracker* tracker =
+      feature_engagement::TrackerFactory::GetForBrowserContext(
+          web_contents->GetBrowserContext());
+  tracker->NotifyEvent(feature_engagement::events::kPwaInstallMenuSelected);
+}
 #endif
 
 }  // namespace webapps

chrome/browser/webapps/chrome_webapps_client.h

@@ -29,6 +29,8 @@ class ChromeWebappsClient : public WebappsClient {
   bool IsInstallationInProgress(content::WebContents* web_contents,
                                 const GURL& manifest_url) override;
   bool CanShowAppBanners(content::WebContents* web_contents) override;
+  void OnWebApkInstallInitiatedFromAppMenu(
+      content::WebContents* web_contents) override;
 #endif
 
  private:

components/webapps/webapps_client.h

@@ -50,6 +50,9 @@ class WebappsClient {
                                         const GURL& manifest_url) = 0;
 
   virtual bool CanShowAppBanners(content::WebContents* web_contents) = 0;
+
+  virtual void OnWebApkInstallInitiatedFromAppMenu(
+      content::WebContents* web_contents) = 0;
 #endif
 };