Add ntlm_enabled parameter to SmbProviderClient::Mount

Adds bool parameter for enabling/disabling NTLM on Mount.

Bug: chromium:888096
Change-Id: Ie2f380da0965472b663b8997d21de1c727edb718
Reviewed-on: https://chromium-review.googlesource.com/c/1259286Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598882}

chrome/browser/chromeos/smb_client/smb_service.cc

@@ -196,7 +196,7 @@ void SmbService::CallMount(const file_system_provider::MountOptions& options,
           : base::FilePath(share_finder_->GetResolvedUrl(parsed_url));
 
   GetSmbProviderClient()->Mount(
-      mount_path, workgroup, username,
+      mount_path, IsNTLMAuthenticationEnabled(), workgroup, username,
       temp_file_manager_->WritePasswordToFile(password),
       base::BindOnce(&SmbService::OnMountResponse, AsWeakPtr(),
                      base::Passed(&callback), options, share_path,

chromeos/dbus/fake_smb_provider_client.cc

@@ -41,6 +41,7 @@ void FakeSmbProviderClient::AddNetBiosPacketParsingForTesting(
 void FakeSmbProviderClient::Init(dbus::Bus* bus) {}
 
 void FakeSmbProviderClient::Mount(const base::FilePath& share_path,
+                                  bool ntlm_enabled,
                                   const std::string& workgroup,
                                   const std::string& username,
                                   base::ScopedFD password_fd,

chromeos/dbus/fake_smb_provider_client.h

@@ -29,6 +29,7 @@ class CHROMEOS_EXPORT FakeSmbProviderClient : public SmbProviderClient {
 
   // SmbProviderClient override.
   void Mount(const base::FilePath& share_path,
+             bool ntlm_enabled,
              const std::string& workgroup,
              const std::string& username,
              base::ScopedFD password_fd,

chromeos/dbus/smb_provider_client.cc

@@ -56,6 +56,14 @@ bool ParseDeleteList(const base::ScopedFD& fd,
          delete_list->ParseFromArray(buffer.data(), buffer.size());
 }
 
+std::unique_ptr<smbprovider::MountConfigProto> CreateMountConfigProto(
+    bool enable_ntlm) {
+  auto mount_config = std::make_unique<smbprovider::MountConfigProto>();
+  mount_config->set_enable_ntlm(enable_ntlm);
+
+  return mount_config;
+}
+
 class SmbProviderClientImpl : public SmbProviderClient {
  public:
   SmbProviderClientImpl() = default;
@@ -63,6 +71,7 @@ class SmbProviderClientImpl : public SmbProviderClient {
   ~SmbProviderClientImpl() override {}
 
   void Mount(const base::FilePath& share_path,
+             bool ntlm_enabled,
              const std::string& workgroup,
              const std::string& username,
              base::ScopedFD password_fd,
@@ -72,6 +81,10 @@ class SmbProviderClientImpl : public SmbProviderClient {
     options.set_workgroup(workgroup);
     options.set_username(username);
 
+    std::unique_ptr<smbprovider::MountConfigProto> config =
+        CreateMountConfigProto(ntlm_enabled);
+    options.set_allocated_mount_config(config.release());
+
     dbus::MethodCall method_call(smbprovider::kSmbProviderInterface,
                                  smbprovider::kMountMethod);
     dbus::MessageWriter writer(&method_call);

chromeos/dbus/smb_provider_client.h

@@ -62,6 +62,7 @@ class CHROMEOS_EXPORT SmbProviderClient
   // credentials to access the mount. |callback| is called after getting (or
   // failing to get) D-BUS response.
   virtual void Mount(const base::FilePath& share_path,
+                     bool ntlm_enabled,
                      const std::string& workgroup,
                      const std::string& username,
                      base::ScopedFD password_fd,