Commit e5f0651d authored by Ian Wells's avatar Ian Wells Committed by Commit Bot

Enable offline pages prefetching flag

Sets the offline pages prefetching feature flag to be enabled by
default.

Bug: 881120
Change-Id: I735723193fbb19100e6962b8861d4fd04933e4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562295Reviewed-by: default avatarDan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654675}
parent 53bd0afa
...@@ -226,7 +226,7 @@ TEST_F(ClientPolicyControllerTest, CheckSuggestedArticlesDefined) { ...@@ -226,7 +226,7 @@ TEST_F(ClientPolicyControllerTest, CheckSuggestedArticlesDefined) {
EXPECT_TRUE(isTemporary(policy)); EXPECT_TRUE(isTemporary(policy));
EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kSuggestedArticlesNamespace)); EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kSuggestedArticlesNamespace));
ExpectRemovedOnCacheReset(kSuggestedArticlesNamespace, true); ExpectRemovedOnCacheReset(kSuggestedArticlesNamespace, true);
ExpectDownloadSupport(kSuggestedArticlesNamespace, false); ExpectDownloadSupport(kSuggestedArticlesNamespace, true);
ExpectUserRequestedDownloadSupport(kSuggestedArticlesNamespace, false); ExpectUserRequestedDownloadSupport(kSuggestedArticlesNamespace, false);
ExpectRecentTab(kSuggestedArticlesNamespace, false); ExpectRecentTab(kSuggestedArticlesNamespace, false);
ExpectRestrictedToTabFromClientId(kSuggestedArticlesNamespace, false); ExpectRestrictedToTabFromClientId(kSuggestedArticlesNamespace, false);
......
...@@ -39,7 +39,7 @@ const base::Feature kOfflinePagesResourceBasedSnapshotFeature{ ...@@ -39,7 +39,7 @@ const base::Feature kOfflinePagesResourceBasedSnapshotFeature{
"OfflinePagesResourceBasedSnapshot", base::FEATURE_DISABLED_BY_DEFAULT}; "OfflinePagesResourceBasedSnapshot", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kPrefetchingOfflinePagesFeature{ const base::Feature kPrefetchingOfflinePagesFeature{
"OfflinePagesPrefetching", base::FEATURE_DISABLED_BY_DEFAULT}; "OfflinePagesPrefetching", base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kOfflinePagesCTV2Feature{"OfflinePagesCTV2", const base::Feature kOfflinePagesCTV2Feature{"OfflinePagesCTV2",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
......
...@@ -43,13 +43,13 @@ TEST(OfflinePageFeatureTest, OfflinePagesLoadSignalCollecting) { ...@@ -43,13 +43,13 @@ TEST(OfflinePageFeatureTest, OfflinePagesLoadSignalCollecting) {
} }
TEST(OfflinePageFeatureTest, OfflinePagesPrefetching) { TEST(OfflinePageFeatureTest, OfflinePagesPrefetching) {
// Disabled by default. // Enabled by default.
EXPECT_FALSE(offline_pages::IsPrefetchingOfflinePagesEnabled()); EXPECT_TRUE(offline_pages::IsPrefetchingOfflinePagesEnabled());
// Check if helper method works correctly when the features is enabled. // Check if helper method works correctly when the features is disabled.
base::test::ScopedFeatureList scoped_feature_list; base::test::ScopedFeatureList scoped_feature_list;
scoped_feature_list.InitAndEnableFeature(kPrefetchingOfflinePagesFeature); scoped_feature_list.InitAndDisableFeature(kPrefetchingOfflinePagesFeature);
EXPECT_TRUE(offline_pages::IsPrefetchingOfflinePagesEnabled()); EXPECT_FALSE(offline_pages::IsPrefetchingOfflinePagesEnabled());
} }
TEST(OfflinePageFeatureTest, OfflinePagesInDownloadHomeOpenInCct) { TEST(OfflinePageFeatureTest, OfflinePagesInDownloadHomeOpenInCct) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment