Commit e6016d73 authored by rnephew's avatar rnephew Committed by Commit Bot

[Telemetry] Re-enable disabled startup benchmark.

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I284c50323936661406074429869fdb990dae99d0
Reviewed-on: https://chromium-review.googlesource.com/562319Reviewed-by: default avatarrnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485399}
parent 21c46cbe
This diff is collapsed.
This diff is collapsed.
...@@ -31,8 +31,6 @@ class _StartupPerfBenchmark(perf_benchmark.PerfBenchmark): ...@@ -31,8 +31,6 @@ class _StartupPerfBenchmark(perf_benchmark.PerfBenchmark):
@benchmark.Enabled('has tabs') @benchmark.Enabled('has tabs')
@benchmark.Enabled('android')
@benchmark.Disabled('chromeos', 'linux', 'mac', 'win')
@benchmark.Owner(emails=['pasko@chromium.org']) @benchmark.Owner(emails=['pasko@chromium.org'])
class StartWithUrlColdTBM(_StartupPerfBenchmark): class StartWithUrlColdTBM(_StartupPerfBenchmark):
"""Measures time to start Chrome cold with startup URLs.""" """Measures time to start Chrome cold with startup URLs."""
...@@ -58,9 +56,6 @@ class StartWithUrlColdTBM(_StartupPerfBenchmark): ...@@ -58,9 +56,6 @@ class StartWithUrlColdTBM(_StartupPerfBenchmark):
@benchmark.Enabled('has tabs') @benchmark.Enabled('has tabs')
@benchmark.Enabled('android')
@benchmark.Disabled('android-reference') # crbug.com/588786
@benchmark.Disabled('chromeos', 'linux', 'mac', 'win')
@benchmark.Owner(emails=['pasko@chromium.org']) @benchmark.Owner(emails=['pasko@chromium.org'])
class StartWithUrlWarmTBM(_StartupPerfBenchmark): class StartWithUrlWarmTBM(_StartupPerfBenchmark):
"""Measures stimetime to start Chrome warm with startup URLs.""" """Measures stimetime to start Chrome warm with startup URLs."""
......
...@@ -37,8 +37,6 @@ class _StartupWarm(perf_benchmark.PerfBenchmark): ...@@ -37,8 +37,6 @@ class _StartupWarm(perf_benchmark.PerfBenchmark):
return startup.Startup(cold=False) return startup.Startup(cold=False)
@benchmark.Disabled('snowleopard') # crbug.com/336913
@benchmark.Disabled('android')
class StartupColdBlankPage(_StartupCold): class StartupColdBlankPage(_StartupCold):
"""Measures cold startup time with a clean profile.""" """Measures cold startup time with a clean profile."""
tag = 'cold' tag = 'cold'
...@@ -51,11 +49,11 @@ class StartupColdBlankPage(_StartupCold): ...@@ -51,11 +49,11 @@ class StartupColdBlankPage(_StartupCold):
def GetExpectations(self): def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations): class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self): def SetExpectations(self):
pass # blank_page.html not disabled. self.PermanentlyDisableBenchmark(
[story.expectations.ALL_ANDROID], 'Non Android benchmark')
return StoryExpectations() return StoryExpectations()
@benchmark.Disabled('android')
class StartupWarmBlankPage(_StartupWarm): class StartupWarmBlankPage(_StartupWarm):
"""Measures warm startup time with a clean profile.""" """Measures warm startup time with a clean profile."""
tag = 'warm' tag = 'warm'
...@@ -65,12 +63,15 @@ class StartupWarmBlankPage(_StartupWarm): ...@@ -65,12 +63,15 @@ class StartupWarmBlankPage(_StartupWarm):
def Name(cls): def Name(cls):
return 'startup.warm.blank_page' return 'startup.warm.blank_page'
def GetExpectations(self):
class StoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
self.PermanentlyDisableBenchmark(
[story.expectations.ALL_ANDROID], 'Non Android benchmark')
return StoryExpectations()
@benchmark.Disabled('reference', # http://crbug.com/476882 @benchmark.Disabled('content-shell') # No pregenerated profiles.
'android', # http://crbug.com/481919
'yosemite', # http://crbug.com/605485
'mac', # http://crbug.com/700843
'content-shell') # No pregenerated profiles.
class StartupLargeProfileColdBlankPage(_StartupCold): class StartupLargeProfileColdBlankPage(_StartupCold):
"""Measures cold startup time with a large profile.""" """Measures cold startup time with a large profile."""
tag = 'cold' tag = 'cold'
...@@ -94,12 +95,7 @@ class StartupLargeProfileColdBlankPage(_StartupCold): ...@@ -94,12 +95,7 @@ class StartupLargeProfileColdBlankPage(_StartupCold):
return StoryExpectations() return StoryExpectations()
@benchmark.Disabled('reference', # http://crbug.com/476882 @benchmark.Disabled('content-shell') # No pregenerated profiles.
'android', # http://crbug.com/481919
'yosemite', # http://crbug.com/605485
'mac', # http://crbug.com/700843
'win', # http://crbug.com/704137
'content-shell') # No pregenerated profiles.
class StartupLargeProfileWarmBlankPage(_StartupWarm): class StartupLargeProfileWarmBlankPage(_StartupWarm):
"""Measures warm startup time with a large profile.""" """Measures warm startup time with a large profile."""
tag = 'warm' tag = 'warm'
......
...@@ -61,11 +61,15 @@ class StartupPagesPageSet(story.StorySet): ...@@ -61,11 +61,15 @@ class StartupPagesPageSet(story.StorySet):
# TODO(rnephew): Test if kapook.com fails on both or just one of the configs. # TODO(rnephew): Test if kapook.com fails on both or just one of the configs.
class WarmStartupStoryExpectations(story.expectations.StoryExpectations): class WarmStartupStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self): def SetExpectations(self):
self.PermanentlyDisableBenchmark(
[story.expectations.ALL_DESKTOP], 'Mobile benchmark')
self.DisableStory( self.DisableStory(
'http://kapook.com', [story.expectations.ALL], 'crbug.com/667470') 'http://kapook.com', [story.expectations.ALL], 'crbug.com/667470')
class ColdStartupStoryExpectations(story.expectations.StoryExpectations): class ColdStartupStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self): def SetExpectations(self):
self.PermanentlyDisableBenchmark(
[story.expectations.ALL_DESKTOP], 'Mobile benchmark')
self.DisableStory( self.DisableStory(
'http://kapook.com', [story.expectations.ALL], 'crbug.com/667470') 'http://kapook.com', [story.expectations.ALL], 'crbug.com/667470')
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment