Commit e6121de7 authored by nednguyen's avatar nednguyen Committed by Commit bot

Switch rasterize_and_record_micro measurement to use RunPageInteractions.

After  https://codereview.chromium.org/966283002,
https://codereview.chromium.org/926213002,
https://codereview.chromium.org/927763002, all the pages used
with raterize_and_record_micro do not issue any interactions
in RunPageInteractions method, should this change should
not cause any functional changes to how the pages get run.

BUG=418375

Review URL: https://codereview.chromium.org/973173002

Cr-Commit-Position: refs/heads/master@{#318943}
parent a928808e
...@@ -9,8 +9,6 @@ import optparse ...@@ -9,8 +9,6 @@ import optparse
import logging import logging
import unittest import unittest
from measurements import rasterize_and_record_micro
from telemetry import benchmark as benchmark_module from telemetry import benchmark as benchmark_module
from telemetry.core import discover from telemetry.core import discover
from telemetry.page import page_test from telemetry.page import page_test
...@@ -66,8 +64,6 @@ class MeasurementSmokeTest(unittest.TestCase): ...@@ -66,8 +64,6 @@ class MeasurementSmokeTest(unittest.TestCase):
def testNoNewActionNameToRunUsed(self): def testNoNewActionNameToRunUsed(self):
invalid_tests = [] invalid_tests = []
for test in _GetAllPossiblePageTestInstances(): for test in _GetAllPossiblePageTestInstances():
if isinstance(test, rasterize_and_record_micro.RasterizeAndRecordMicro):
continue
if not hasattr(test, 'action_name_to_run'): if not hasattr(test, 'action_name_to_run'):
invalid_tests.append(test) invalid_tests.append(test)
logging.error('Test %s missing action_name_to_run attribute.', logging.error('Test %s missing action_name_to_run attribute.',
......
...@@ -13,7 +13,8 @@ from telemetry.value import scalar ...@@ -13,7 +13,8 @@ from telemetry.value import scalar
class RasterizeAndRecordMicro(page_test.PageTest): class RasterizeAndRecordMicro(page_test.PageTest):
def __init__(self, start_wait_time=2, rasterize_repeat=100, record_repeat=100, def __init__(self, start_wait_time=2, rasterize_repeat=100, record_repeat=100,
timeout=120, report_detailed_results=False): timeout=120, report_detailed_results=False):
super(RasterizeAndRecordMicro, self).__init__('') super(RasterizeAndRecordMicro, self).__init__(
action_name_to_run='RunPageInteractions')
self._chrome_branch_number = None self._chrome_branch_number = None
self._start_wait_time = start_wait_time self._start_wait_time = start_wait_time
self._rasterize_repeat = rasterize_repeat self._rasterize_repeat = rasterize_repeat
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment