Remove use counters for non-square radio/checkbox

These counters were added in [1], and data was gathered. It turns out
that about 7% of all visible radio buttons and 11% of all visible
checkboxes are "non-square" - their width != height. With the
existing code, these are rendered square, using min(width,height).
But the point is that if we relaxed this constraint, 7-11% of page
loads would change - a huge web compat problem.

Now that data gathering is complete, I'm removing these counters.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1967426

Change-Id: I6f2334d04a2dcd62b71ce428cd2d13c16b5e59c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088334
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748927}

components/page_load_metrics/browser/observers/use_counter/ukm_features.cc

@@ -147,8 +147,6 @@ UseCounterPageLoadMetricsObserver::GetAllowedUkmFeatures() {
           WebFeature::kWebBluetoothRequestScan,
           WebFeature::
               kV8VideoPlaybackQuality_CorruptedVideoFrames_AttributeGetter,
-          WebFeature::kInputTypeCheckboxRenderedNonSquare,
-          WebFeature::kInputTypeRadioRenderedNonSquare,
           WebFeature::kV8MediaSession_Metadata_AttributeSetter,
           WebFeature::kV8MediaSession_SetActionHandler_Method,
           WebFeature::kLargeStickyAd,

third_party/blink/public/mojom/web_feature/web_feature.mojom

@@ -2453,8 +2453,8 @@ enum WebFeature {
   kLongTaskBufferFull = 3118,
   kHTMLMetaElementMonetization = 3119,
   kHTMLLinkElementMonetization = 3120,
-  kInputTypeCheckboxRenderedNonSquare = 3121,
-  kInputTypeRadioRenderedNonSquare = 3122,
+  kInputTypeCheckboxRenderedNonSquare_Obsolete = 3121,
+  kInputTypeRadioRenderedNonSquare_Obsolete = 3122,
   kWebkitBoxPackJustifyDoesSomething = 3123,
   kWebkitBoxPackCenterDoesSomething = 3124,
   kWebkitBoxPackEndDoesSomething = 3125,

third_party/blink/renderer/core/paint/theme_painter.cc

@@ -143,18 +143,10 @@ bool ThemePainter::Paint(const LayoutObject& o,
   switch (part) {
     case kCheckboxPart: {
       COUNT_APPEARANCE(doc, Checkbox);
-      // Count usage of non-rectangular checkbox and radio buttons.
-      if (r.Width() != r.Height()) {
-        UseCounter::Count(doc, WebFeature::kInputTypeCheckboxRenderedNonSquare);
-      }
       return PaintCheckbox(node, o.GetDocument(), style, paint_info, r);
     }
     case kRadioPart: {
       COUNT_APPEARANCE(doc, Radio);
-      // Count usage of non-rectangular checkbox and radio buttons.
-      if (r.Width() != r.Height()) {
-        UseCounter::Count(doc, WebFeature::kInputTypeRadioRenderedNonSquare);
-      }
       return PaintRadio(node, o.GetDocument(), style, paint_info, r);
     }
     case kPushButtonPart: {

tools/metrics/histograms/enums.xml

@@ -26698,8 +26698,8 @@ to ensure that the crash string is shown properly on the user-facing crash UI.
   <int value="3118" label="LongTaskBufferFull"/>
   <int value="3119" label="HTMLMetaElementMonetization"/>
   <int value="3120" label="HTMLLinkElementMonetization"/>
-  <int value="3121" label="InputTypeCheckboxRenderedNonSquare"/>
-  <int value="3122" label="InputTypeRadioRenderedNonSquare"/>
+  <int value="3121" label="InputTypeCheckboxRenderedNonSquare_Obsolete"/>
+  <int value="3122" label="InputTypeRadioRenderedNonSquare_Obsolete"/>
   <int value="3123" label="WebkitBoxPackJustifyDoesSomething"/>
   <int value="3124" label="WebkitBoxPackCenterDoesSomething"/>
   <int value="3125" label="WebkitBoxPackEndDoesSomething"/>