Add crash dump error reporting for OOP-R deserialization failures

There was a recent issue where this was happening due to cache bugs.
This is something that should never happen, so it would be nice to have
it be more noisy when it fails.

Bug: 906510
Change-Id: Ie4e8aaf415c491d4ba192d1b57c115cec7d81ca9
Reviewed-on: https://chromium-review.googlesource.com/c/1351386Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611217}

cc/paint/paint_op_buffer.h

@@ -184,8 +184,10 @@ class CC_PAINT_EXPORT PaintOp {
                        SkStrikeClient* strike_client);
     TransferCacheDeserializeHelper* transfer_cache = nullptr;
     ServicePaintCache* paint_cache = nullptr;
-    uint32_t raster_color_space_id = gfx::ColorSpace::kInvalidId;
     SkStrikeClient* strike_client = nullptr;
+    uint32_t raster_color_space_id = gfx::ColorSpace::kInvalidId;
+    // Do a DumpWithoutCrashing when serialization fails.
+    bool crash_dump_on_failure = false;
   };
 
   // Indicates how PaintImages are serialized.

cc/paint/paint_op_reader.cc

@@ -8,6 +8,7 @@
 #include <algorithm>
 
 #include "base/bits.h"
+#include "base/debug/dump_without_crashing.h"
 #include "base/stl_util.h"
 #include "cc/paint/image_transfer_cache_entry.h"
 #include "cc/paint/paint_cache.h"
@@ -613,6 +614,8 @@ void PaintOpReader::AlignMemory(size_t alignment) {
 }
 
 inline void PaintOpReader::SetInvalid() {
+  if (valid_ && options_.crash_dump_on_failure)
+    base::debug::DumpWithoutCrashing();
   valid_ = false;
 }
 

gpu/command_buffer/service/raster_decoder.cc

@@ -2564,8 +2564,8 @@ void RasterDecoderImpl::DoRasterCHROMIUM(GLuint raster_shm_id,
   TransferCacheDeserializeHelperImpl impl(raster_decoder_id_, transfer_cache());
   cc::PaintOp::DeserializeOptions options(&impl, paint_cache_.get(),
                                           font_manager_->strike_client());
+  options.crash_dump_on_failure = true;
 
-  int op_idx = 0;
   size_t paint_buffer_size = raster_shm_size;
   while (paint_buffer_size > 0) {
     size_t skip = 0;
@@ -2573,9 +2573,8 @@ void RasterDecoderImpl::DoRasterCHROMIUM(GLuint raster_shm_id,
         paint_buffer_memory, paint_buffer_size, &data[0],
         sizeof(cc::LargestPaintOp), &skip, options);
     if (!deserialized_op) {
-      std::string msg =
-          base::StringPrintf("RasterCHROMIUM: bad op: %i", op_idx);
-      LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glRasterCHROMIUM", msg.c_str());
+      LOCAL_SET_GL_ERROR(GL_INVALID_OPERATION, "glRasterCHROMIUM",
+                         "RasterCHROMIUM: serialization failure");
       return;
     }
 
@@ -2584,7 +2583,6 @@ void RasterDecoderImpl::DoRasterCHROMIUM(GLuint raster_shm_id,
 
     paint_buffer_size -= skip;
     paint_buffer_memory += skip;
-    op_idx++;
   }
 }