Commit e6431236 authored by Ken Rockot's avatar Ken Rockot Committed by Commit Bot

data_decoder: Use inline bitmap data for animations

Using a normal skia Bitmap mojom type means that large frames may be
transmitted as shared memory regions, which in turn means that
animations with more than 64 large frames can cause DecodeAnimation's
reply to exceed Mojo's self-imposed per-message handle limitation.

This is a temporary solution which restores DecodeAnimation to using
inline bitmap data (which it did prior to CL:1004598).

Bug: 838706
Change-Id: I53542a0070b6d554b52c6b0e3576b94af233a9f4
Reviewed-on: https://chromium-review.googlesource.com/1038760Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555293}
parent bff7e1e9
......@@ -15,7 +15,9 @@ enum ImageCodec {
};
struct AnimationFrame {
skia.mojom.Bitmap bitmap;
// TODO(https://crbug.com/838706): Cnonsider replacing individual Bitmap
// structs with a new type that uses a single BigBuffer for all frame data.
skia.mojom.InlineBitmap bitmap;
mojo_base.mojom.TimeDelta duration;
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment